Bug 10956 - REGRESSION: Gradient-stroked Text no longer works
Summary: REGRESSION: Gradient-stroked Text no longer works
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: NeedsReduction, Regression
Depends on:
Blocks:
 
Reported: 2006-09-20 15:46 PDT by Eric Seidel (no email)
Modified: 2006-12-17 13:45 PST (History)
0 users

See Also:

Attachments
Initial patch (143.24 KB, patch)
2006-12-17 13:25 PST, Nikolas Zimmermann 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-09-20 15:46:40 PDT 
I'm not sure when this happened, but it must have been in the last few weeks.

Gradient-stroked text, such as is found in:
W3C-SVG-1.1/pservers-grad-08-b
W3C-SVG-1.1/pservers-grad-11-b

no longer works.  It used to.

Marking this as only a P2 since we've never shipped SVG.
Comment 1 Nikolas Zimmermann 2006-12-17 12:47:50 PST 
It took a good hour, but I could finally track down to the range:
16288 (broken) - 16284 (working)

Only 16286 is svg related:
http://trac.webkit.org/projects/webkit/changeset/16286

Starting to investigate.
Comment 2 Nikolas Zimmermann 2006-12-17 13:25:08 PST 
Created attachment 11896 [details]
Initial patch

Fix gradient on stroke of text. Radial & linear gradients both work properly now.
Comment 3 Eric Seidel (no email) 2006-12-17 13:37:02 PST 
Comment on attachment 11896 [details]
Initial patch

Looks fine.

You can remove the outdated comment about pen vs. fill/stroke, or update it to explain why we need to set both fill & stroke.
Comment 4 Nikolas Zimmermann 2006-12-17 13:45:37 PST 
Landed in r18271.