RESOLVED INVALID 10950
Need way for embedders to provide link coloring on Windows 
https://bugs.webkit.org/show_bug.cgi?id=10950
Summary Need way for embedders to provide link coloring on Windows
Brett Wilson (Google)
Reported 2006-09-20 10:11:10 PDT
On Mac, I believe an embedder can use objective C to implement WebKit/WebKit/History/WebHistoryPrivate.h On Windows, historyContains() is stubbed out in WebKit/WebCore/platform/win/TemporaryLinkStubs.cpp to return false. It should be possible for an embedder on Windows to provide an implementation for this function.
Attachments
Patch to add WebKitInstance and WebHistoryDelegate (14.21 KB, patch)
2006-09-20 11:25 PDT, Brett Wilson (Google) 		darin: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brett Wilson (Google)
Comment 1 2006-09-20 11:25:12 PDT
Created attachment 10672 [details] Patch to add WebKitInstance and WebHistoryDelegate This patch adds a singleton COM object IWebKitInstance that embedders can access. It seems like there will be a variety of global controls that embedders will need access to, and this interface would be used to manage those things. It adds an interface IWebHistoryDelegate and a setter for this on the WebKitInstance. The embedder would implement IWebHistoryDelegate which would then get called for coloring links. In this patch, WebCore::historyContains is implemented in the WebKitInstance file. From my understanding of the direction WebKit is going, the difference between WebKit and WebCore is being moved or decreased. Link coloring is also performance critical, so I wanted to decrease the number of abstraction layers that it has to go through (I think this one COM layer is still more than I would prefer).
Dave Hyatt
Comment 2 2006-09-20 22:15:23 PDT
Comment on attachment 10672 [details] Patch to add WebKitInstance and WebHistoryDelegate r=me
Darin Adler
Comment 3 2006-09-21 11:42:54 PDT
Comment on attachment 10672 [details] Patch to add WebKitInstance and WebHistoryDelegate This patch looks good, but I don't think it's the way we want to go. We'd like the history to be maintained inside WebKit as it is in the Macintosh version of WebKit. And in fact someone on my team has made some progress implementing this and should have something to check in soon; that will probably be Adam Roben. Setting this to review- for now until we work this out.
Brett Wilson (Google)
Comment 4 2007-06-14 16:46:26 PDT
I think this is unnecessary now.
Note You need to log in before you can comment on or make changes to this bug.