Bug 10946 – new marker code draws end-marker in wrong place

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

new marker code draws end-marker in wrong place

I caused a regression for marker drawing with my new marker code.  I've attached a reduction.  Should be simple to fix.

[Eric Seidel (no email)]

Created attachment 10664 [details]
test case, should show 100x100 green block when correct

[Rob Buis]

(In reply to comment #1)
> Created an attachment (id=10664) [edit]
> test case, should show 100x100 green block when correct

Just so that nobody wastes time on fixing this, I have a working patch. I'll upload it soon.
Cheers,

Rob.

[Rob Buis]

Created attachment 10673 [details]
First attempt

This fixes the problem, I think this problem was always there, but Erics clipping
fixes probably really showed it.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 10673 [details]
First attempt

This looks like a great fix.  I'm not quite sure why we need to store both origin as well as subpathStart, so perhaps you can explain that to me over IRC before landing.  Overall this looks fabulous though.  r=me.

[Rob Buis]

(In reply to comment #4)
> (From update of attachment 10673 [details] [edit])
> This looks like a great fix.  I'm not quite sure why we need to store both
> origin as well as subpathStart, so perhaps you can explain that to me over IRC
> before landing.  Overall this looks fabulous though.  r=me.
> 

That will be hard, since you are not on IRC :) Anyway origin seems different,
it seems to be more like "current point" and changes for each path iteration. So I think
subpathStart is really needed.
Cheers,

Rob.

[Rob Buis]

Landed in r16494.