Bug 10940 – REGRESSION: WebKit crashes when opening a PDF in a new window

• Status: VERIFIED
• Resolution: FIXED
• Component: New Bugs

[Mark Rowe (bdash)]

Steps to reproduce:

1) Visit http://www.math.tamu.edu/~austin/wirmath151.html
2) Right click on 'Week 1 in Review' and select "Open Link in New Window"
3) *boom*

Backtrace follows.

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_PROTECTION_FAILURE (0x0002) at 0x000006f4

Thread 0 Crashed:
0   com.apple.WebCore        	0x0111095d WebCore::Document::iconURL() + 9
1   com.apple.WebCore        	0x010f107b WebCore::Frame::iconURL() + 99
2   com.apple.WebCore        	0x010f16a1 WebCore::Frame::endIfNotLoading() + 293
3   com.apple.WebKit         	0x00379fe3 -[WebFrameLoader _finishedLoading] + 73
4   com.apple.WebKit         	0x0037d281 -[WebMainResourceLoader didFinishLoading] + 55
5   com.apple.WebKit         	0x0037c1f2 -[WebLoader connectionDidFinishLoading:] + 40
6   com.apple.Foundation     	0x9278fa6c -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] + 176
7   com.apple.Foundation     	0x9278db15 -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] + 748
8   com.apple.Foundation     	0x9278d7b3 _sendCallbacks + 201
9   com.apple.CoreFoundation 	0x90823379 CFRunLoopRunSpecific + 1213
10  com.apple.CoreFoundation 	0x90822eb5 CFRunLoopRunInMode + 61
11  com.apple.HIToolbox      	0x92f02b90 RunCurrentEventLoopInMode + 285
12  com.apple.HIToolbox      	0x92f02297 ReceiveNextEventCommon + 385
13  com.apple.HIToolbox      	0x92f020ee BlockUntilNextEventMatchingListInMode + 81
14  com.apple.AppKit         	0x933a3771 _DPSNextEvent + 576
15  com.apple.AppKit         	0x933a335e -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 137
16  com.apple.Safari         	0x00006f96 0x1000 + 24470
17  com.apple.AppKit         	0x9339d0e3 -[NSApplication run] + 512
18  com.apple.AppKit         	0x93391037 NSApplicationMain + 573
19  com.apple.Safari         	0x0005f7de 0x1000 + 387038
20  com.apple.Safari         	0x0005f6f9 0x1000 + 386809

[Brady Eidson]

When you open a PDF in a new frame, that frame doesn't have a Document, but we don't check for a NULL document()

Patch is coming very shortly

[R. Tyler Ballance]

(In reply to comment #0)
> Steps to reproduce:
> 

Thanks Mark, I'm not in a good mood today, exam tomorrow ;)

[Brady Eidson]

Created attachment 10656 [details]
The Fix!

After determining the root of the problem, thankfully t'was a one-liner fix

[Kevin McCullough]

Comment on attachment 10656 [details]
The Fix!

looks sweet

[Brady Eidson]

Submitted in r16457, please verify

[Mark Rowe (bdash)]

Excellent!