Bug 10927 – ResourceLoaderClient::receivedRedirect is never called

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Darin Fisher (:fishd, Google)]

ResourceLoaderClient::receivedRedirect is never called

[Darin Fisher (:fishd, Google)]

Related to this bug is the fact that IWebFrameLoadDelegate's didReceiveServerRedirectForProvisionalLoadForFrame method is not called.  (Man, that's a long method name!)

[Darin Fisher (:fishd, Google)]

Created attachment 10636 [details]
patch

This patch makes it so that client()->receivedRedirect is called.

I also took a stab at cleaning up the large WndProc in ResourceLoaderWin.cpp.  I found a way to avoid the heap-allocated struct passed to PostMessage, and I also got rid of the unnecessary call to RegisterWindowMessage, replacing it with WM_USER + N.  I hope you will consider these changes as I believe they make ResourceLoaderWin.cpp much more manageable.

The code for INTERNET_STATUS_USER_INPUT_REQUIRED is needed in case WinInet is configured to prompt on security warnings, etc.

[Darin Fisher (:fishd, Google)]

It turns out that this patch also fixes bug 10744.  That bug is caused by the fact that we do not respond to INTERNET_STATUS_USER_INPUT_REQUIRED.

[Darin Fisher (:fishd, Google)]

Created attachment 10697 [details]
revised patch per feedback from maciej

Revised patch.  Got rid of "k" prefixes on variables.  Switched from UINT to int where appropriate.

[Brady Eidson]

Comment on attachment 10697 [details]
revised patch per feedback from maciej

This is pretty good, but it misses one important thing - note my follow up patch and how it sets the error code in the ResourceLoader (which is used elsewhere!)

[Brady Eidson]

Created attachment 10698 [details]
New patch with some small (critical) fixes

I think I can get someone else to review this tonite (I'll email the team)

[Darin Fisher (:fishd, Google)]

Please note the changes between my first and second patches.  The latest patch undoes the changes that Maciej recommended.

[Brady Eidson]

I completely didn't realize that there was a follow up that contained feedback from maciej.

I just checked in my version, but I will go back and merge the changes maciej originally requested into what I decided on

[Brady Eidson]

Commited in r16526

[Adam Roben (:aroben)]

Comment on attachment 10698 [details]
New patch with some small (critical) fixes

Clearing review flag