WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
10882
SVG needs Obj-C DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=10882
Summary
SVG needs Obj-C DOM bindings
Eric Seidel (no email)
Reported
2006-09-16 01:34:57 PDT
SVG needs Obj-C DOM bindings This shouldn't be very hard since all of the SVG DOM bindings are auto-generated, and all of the SVG JS DOM bindings are back in working order. The only "challenge" in this patch will be adding multiple inheritance support to the Obj-C DOM binding generator. I would suggest using Obj-C protocols.
Attachments
patch
(50.16 KB, patch)
2006-09-24 13:38 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
patch 2
(52.11 KB, patch)
2006-09-24 13:46 PDT
,
Sam Weinig
timothy
: review+
Details
Formatted Diff
Diff
patch 3
(42.51 KB, patch)
2006-09-24 15:16 PDT
,
Sam Weinig
timothy
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2006-09-24 13:38:42 PDT
Created
attachment 10741
[details]
patch - Auto-generate the first 8 Objective-C SVG DOM bindings. The auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList, DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and DOMSVGTransformList.
Sam Weinig
Comment 2
2006-09-24 13:46:00 PDT
Created
attachment 10742
[details]
patch 2 Updated patch. Had forgotten to svn add DOMSVG.h.
Timothy Hatcher
Comment 3
2006-09-24 14:48:39 PDT
Comment on
attachment 10742
[details]
patch 2 Looks good. I would sugest removing "core::" from core::DOMException. We should be consitent, and we use DOMException more than core::DOMException. r=me either way.
Sam Weinig
Comment 4
2006-09-24 15:16:41 PDT
Created
attachment 10744
[details]
patch 3 Updated Patch. Removes previously commented out "setter raises(DOMException)" statements after a conversation with Wildfox on IRC about it.
Sam Weinig
Comment 5
2006-09-26 06:01:56 PDT
Landed in r 16551.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug