Bug 10864 - Linux\GDK build fixes
Summary: Linux\GDK build fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-14 20:43 PDT by Krzysztof Kowalczyk
Modified: 2006-09-15 17:32 PDT (History)
0 users

See Also:


Attachments
fix linux\gdk build (29.02 KB, patch)
2006-09-14 20:43 PDT, Krzysztof Kowalczyk
aroben: review+
Details | Formatted Diff | Diff
fix the name in ChangeLog and remove tab (29.03 KB, patch)
2006-09-15 01:28 PDT, Krzysztof Kowalczyk
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2006-09-14 20:43:01 PDT
Attached patch fixes GDK build.

The only (I hope) controversial thing is adding #define USE_OLD_CAIRO in FontDataGdk.cpp. If defined, it makes the build compile with older (1.0.4) version of cairo (which seems to be standard on most distros e.g. my Ubuntu 6.06.1) by not using a cairo_scaled_font_text_extents() which is only available in later cairo builds. I think that it's better to have a build working out of the box on popular distros rather than force people to install their own copy of cairo (which is non-trivial for most people).
Comment 1 Krzysztof Kowalczyk 2006-09-14 20:43:29 PDT
Created attachment 10569 [details]
fix linux\gdk build
Comment 2 Adam Roben (:aroben) 2006-09-14 20:56:34 PDT
Comment on attachment 10569 [details]
fix linux\gdk build

It looks like you've got a tab character in WebCore/Projects/gdk/webcore-gdk.bkl

Also, can you remove the commas from the end of your name in the ChangeLog?

Other than those, r=me
Comment 3 Krzysztof Kowalczyk 2006-09-15 01:28:09 PDT
Created attachment 10572 [details]
fix the name in ChangeLog and remove tab

Just like the previous patch with tab in webcore-gdk.bkl removed and the commas after name removed in ChangeLog
Comment 4 Adam Roben (:aroben) 2006-09-15 11:28:33 PDT
Comment on attachment 10572 [details]
fix the name in ChangeLog and remove tab

r=me
Comment 5 Mark Rowe (bdash) 2006-09-15 17:32:53 PDT
Landed in r16382.