Bug 10862 - REGRESSION: Collapsing form input on www.myspace.com
Summary: REGRESSION: Collapsing form input on www.myspace.com
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://www.myspace.com/
Keywords: EasyFix, HasReduction, InRadar, Regression
: 11317 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-14 17:53 PDT by Miles Bainbridge
Modified: 2007-04-27 10:06 PDT (History)
5 users (show)

See Also:


Attachments
Screen shot of collapsed text enry box. (373.01 KB, image/png)
2006-09-14 17:56 PDT, Miles Bainbridge
no flags Details
Reduction (238 bytes, text/html)
2006-09-15 03:57 PDT, mitz
no flags Details
new reduction (215 bytes, text/html)
2006-11-24 11:35 PST, Matt Lilek
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Miles Bainbridge 2006-09-14 17:53:59 PDT
On nightly builds of WebKit (I belive from 9-12-2006 and later), if you go to www.myspace.com, and start typing in the password box, the text input box labeled "E-Mail:" collapses to a width of less than 10 pixels.  If memory serves correctly, I did not experience this on builds from 9-11-2006 and earlier, and I have experienced this on multiple different computers running nightly builds since then, all running Mac OS X 10.4.7.  Also, all of the computers I have tested this on have been PowerPC.  I can attach screen shots if requested.
Comment 1 Miles Bainbridge 2006-09-14 17:56:33 PDT
Created attachment 10562 [details]
Screen shot of collapsed text enry box.

This screen shot is from WebKit nightly build 9-11-2006.  The bug is still occurring in nightly build 9-13-2006
Comment 2 Miles Bainbridge 2006-09-14 17:57:13 PDT
Correction - I have a screen shot on file (which I just attached) that indicates that this bug started occurring with the nightly build from 9-11-2006.
Comment 3 Kevin M. Dean 2006-09-14 20:49:39 PDT
I'm seeing the same. It appears that you have to type at least 1 character in the E-mail field before selecting the password field and type to trigger the problem. If your E-mail is already there and you got directly to the password fiedl and type, everthing's fine.
Comment 4 mitz 2006-09-15 03:57:40 PDT
Created attachment 10573 [details]
Reduction
Comment 5 mitz 2006-09-15 07:35:18 PDT
Very similar to bug 9316!
Comment 6 mitz 2006-09-15 08:24:17 PDT
The wrong layout is the due to the subtree layout mechanism being triggered when it shouldn't be. It happens as a result of calling setNeedsLayout() on a new RenderText which doesn't have a parent yet (this happens under setStyle() under createRendererIfNeeded()). RenderObject::scheduleRelayout() is confused as a result of this. In its "else" case, it should simply do nothing if parent() is 0.
Comment 7 Miles Bainbridge 2006-09-15 12:42:19 PDT
I just did some checking on where this bug orriginated, and it seems to have started appearing in build 16265.  16259 and earlier do not exhibit this, though they have some even more serious layout issues on the same web page.
Comment 8 Stephanie Lewis 2006-11-06 21:26:42 PST
radar 4823120
Comment 9 Kevin B 2006-11-23 18:56:31 PST
this works for me in r17878
Comment 10 mitz 2006-11-23 23:43:05 PST
(In reply to comment #9)
> this works for me in r17878
> 

That's because r17543 moved text controls back to RenderBlock. The root cause of this bug should still be fixed.
Comment 11 Matt Lilek 2006-11-24 10:44:15 PST
I can still reproduce this, but in a different way.  Load myspace.com, enter anything in either the username or password field, then click the the search button in the upper right hand of the page - the text field collapses like before.
Comment 12 Matt Lilek 2006-11-24 11:35:40 PST
Created attachment 11623 [details]
new reduction

This is a reduction for the behavior I described in my last comment.  This bug is identical to bug 9316 except instead of collapsing on a keystroke, it collapses on any kind of a button press (this can be verified by modifying 9316's testcase to include a button).  On myspace, it only happens like I described because "login" and "sign up" are faux buttons.
Comment 13 Matt Lilek 2006-11-25 00:16:57 PST
*** Bug 11317 has been marked as a duplicate of this bug. ***
Comment 14 Adele Peterson 2007-01-17 15:18:07 PST
This appears to be fixed in TOT.
Comment 15 mitz 2007-04-27 10:06:52 PDT
(In reply to comment #10)
> That's because r17543 moved text controls back to RenderBlock. The root cause
> of this bug should still be fixed.
> 

Bug 13525.