Bug 10846 – exceptions from XHTML/SVG <script> tags don't show the right line numbers

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Eric Seidel (no email)]

exceptions from XHTML/SVG <script> tags don't show the right line numbers

This is why:

XMLTokenizer::endElementNs() contains a:
            m_view->frame()->executeScript(0, scriptCode);

call, notice how it fails to pass the correct base line number.

Compare that with the HTML tokenizer, which correctly passes the line number.

We'll have to steal the line number out of:

m_context->input->line when we hit a <script> start tag, and then use that when we actually execute the script.

It shouldn't be too hard.

We might just consider adding a m_startLineNumber member into HTMLScriptElement and SVGScriptElement for simplicity of both tokenizers/parsers.

Adding to the SVG hitlist as this makes SVGs very hard to debug in Safari.

[Eric Seidel (no email)]

Created attachment 10547 [details]
Improves the situation

This "fixes" the bug.  Now line numbers seem to be off-by-one in the other direction.  I'm not sure why.  I could just change the line to m_scriptStartLine - 1, but I'm not sure that's "right".

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> Created an attachment (id=10547) [edit]
> Improves the situation
> 
> This "fixes" the bug.

With just a ChangeLog entry?  :)

[Eric Seidel (no email)]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=10547) [edit]
> > Improves the situation
> > 
> > This "fixes" the bug.
> 
> With just a ChangeLog entry?  :)
> 

You under-estimate the power of the ChangeLog!  Sometimes willing a bug gone is enough. :)

In this case however, a code change would help.  Too bad I tossed the patch thinking it was already safely part of bugzilla.  :(

[Eric Seidel (no email)]

Created attachment 10549 [details]
The fix (now with 100% more code!)

[Dave Hyatt]

Comment on attachment 10549 [details]
The fix (now with 100% more code!)

r=me

[Eric Seidel (no email)]

Drosera works much better now for xhtml/svg. :)

Landed as r16447.