Bug 10838 – REGRESSION: Leaking of WebScriptObjectPrivate

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Rowe (bdash)]

`run-webkit-tests --leaks` generates leak reports that have dozens of WebScriptObjectPrivate's being leaked.   An example of the backtrace is:

	Call stack: [thread 2d63a7]: | 0x0 | start | _start | main | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidReceiveDataCallback] | -[WebLoader connection:didReceiveData:lengthReceived:] | -[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:] | -[WebLoader didReceiveData:lengthReceived:allAtOnce:] | -[WebMainResourceLoader addData:allAtOnce:] | -[WebFrameLoader _receivedData:] | -[WebDataSource(WebInternal) _receivedData:] | -[WebDataSource(WebFileInternal) _commitLoadWithData:] | -[WebHTMLRepresentation receivedData:withDataSource:] | -[WebFrameBridge receivedData:textEncodingName:] | -[WebCoreFrameBridge setEncoding:userChosen:] | WebCore::Frame::setEncoding(WebCore::String const&, bool) | WebCore::Frame::receivedFirstData() | WebCore::Frame::begin(WebCore::KURL const&) | WebCore::FrameMac::partClearedInBegin() | -[WebFrameBridge windowObjectCleared] | -[WebCoreFrameBridge windowScriptObject] | WebCore::FrameMac::windowScriptObject() | -[WebScriptObject _initWithJSObject:originExecutionContext:executionContext:] | NSAllocateObject | _internal_class_createInstanceFromZone 
Leak: 0x1f89dce0  size=32	instance of 'WebScriptObjectPrivate'	
See http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/2531/DumpRenderTree5-leaks.txt for more examples.

[Mark Rowe (bdash)]

The WebScriptObject's and co are expected to be cleaned up from FrameMac::cleanupPluginObjects, but this is never being called.  It is intended to be called from Frame::clear but as cleanupPluginObjects is a virtual method being called from the Frame destructor, the FrameMac subclass portion of the object has already been torn down.

[Mark Rowe (bdash)]

Created attachment 10567 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 10567 [details]
Patch

r=me, although you've got a typo in your ChangeLog: "this its" should be "its"

[Adam Roben (:aroben)]

Comment on attachment 10567 [details]
Patch

Stephanie is going to confirm that this patch helps fix some of our current performance regression, and then give you permission to check in if it does (since the tree is currently closed).

[Mark Rowe (bdash)]

Stephanie gave the go-ahead via IRC, and this was landed as r16368.

[Timothy Hatcher]

This landed in r16368.