Bug 10834 – FileChooser constructor in FileChooserMac appears to overretain m_controller

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Mark Rowe (bdash)]

m_controller's initializer (http://trac.webkit.org/projects/webkit/browser/trunk/WebCore/platform/mac/FileChooserMac.mm?rev=16323#L92) reads:

    , m_controller([[[OpenPanelController alloc] initWithFileChooser:this] retain])

Allocing and then retaining the OpenPanelController seems incorrect to me.  If this is intended, it should have some form of explanatory comment as it's not standard practice.

[Mark Rowe (bdash)]

After trawling through some of Buildbot's leak output, I noticed:

	Call stack: [thread 252f87]: | 0x0 | start | _start | main | runTest | -[NSRunLoop runMode:beforeDate:] | CFRunLoopRunSpecific | __CFRunLoopRun | __CFRunLoopDoSources0 | _sendCallbacks | -[NSURLConnection(NSURLConnectionInternal) _sendCallbacks] | -[NSURLConnection(NSURLConnectionInternal) _sendDidFinishLoadingCallback] | -[WebLoader connectionDidFinishLoading:] | -[WebSubresourceLoader didFinishLoading] | -[WebCoreResourceLoaderImp finishWithData:] | -[WebCoreResourceLoaderImp finishJobAndHandle:] | WebCore::Loader::receivedAllData(WebCore::ResourceLoader*, NSData*) | WebCore::CachedScript::data(WTF::Vector<char, (unsigned long)0>&, bool) | WebCore::CachedScript::checkNotify() | WebCore::HTMLTokenizer::notifyFinished(WebCore::CachedResource*) | WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) | WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) | WebCore::HTMLTokenizer::processToken() | WebCore::HTMLParser::parseToken(WebCore::Token*) | WebCore::HTMLParser::insertNode(WebCore::Node*, bool) | WebCore::HTMLInputElement::attach() | WebCore::HTMLGenericFormElement::attach() | WebCore::Element::attach() | WebCore::Node::createRendererIfNeeded() | WebCore::HTMLInputElement::createRenderer(WebCore::RenderArena*, WebCore::RenderStyle*) | WebCore::RenderFileUploadControl::RenderFileUploadControl[in-charge](WebCore::Node*) | WebCore::FileChooser::FileChooser[in-charge](WebCore::Document*, WebCore::RenderFileUploadControl*) | NSAllocateObject | _internal_class_createInstanceFromZone 
Leak: 0x1d406050  size=16	instance of 'OpenPanelController'	
(http://build.webkit.org/results/post-commit-leaks-powerpc-mac-os-x/2531/DumpRenderTree-leaks.txt)

This seems to confirm that it is being overretained.

[Mark Rowe (bdash)]

Created attachment 10550 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 10550 [details]
Patch

r=me. Thanks for catching this!

[Mark Rowe (bdash)]

Landed in r16358.