WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
10833
Windows build needs fixed after move to engine-rendered file upload widget
https://bugs.webkit.org/show_bug.cgi?id=10833
Summary
Windows build needs fixed after move to engine-rendered file upload widget
Karthik Kumar
Reported
2006-09-13 05:27:22 PDT
TODO: 1. Remove FileButton.h, RenderFileButton.cpp from .vcproj project file (as build fails) 2. Remove #include "FileButton.h" and FileButton:: whatever from TemporaryLinkStubs.cpp
Attachments
patch
(4.65 KB, patch)
2006-09-13 11:19 PDT
,
Darin Fisher (:fishd, Google)
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2006-09-13 05:30:56 PDT
Project file needs references to deleted files removed, references to the new files added, obselete link stubs removed, and new ones added to make things build.
Darin Fisher (:fishd, Google)
Comment 2
2006-09-13 11:19:53 PDT
Created
attachment 10540
[details]
patch This works for me.
Adam Roben (:aroben)
Comment 3
2006-09-13 11:22:27 PDT
Comment on
attachment 10540
[details]
patch r=me, and thanks for including a ChangeLog entry. Ideally you would describe the changes within the ChangeLog, but since this is a build fix I'll go ahead and land it. Thanks!
Adam Roben (:aroben)
Comment 4
2006-09-13 11:42:35 PDT
Comment on
attachment 10540
[details]
patch Landed as
r16346
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug