Bug 10829 - RenderPath::nodeAtPoint does not properly respect stroke width
Summary: RenderPath::nodeAtPoint does not properly respect stroke width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P4 Normal
Assignee: Nobody
URL: http://srufaculty.sru.edu/david.daile...
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-12 18:33 PDT by Eric Seidel (no email)
Modified: 2006-09-26 05:51 PDT (History)
0 users

See Also:


Attachments
The fix (2.92 KB, patch)
2006-09-19 03:39 PDT, Eric Seidel (no email)
mjs: review-
Details | Formatted Diff | Diff
Updated patch with test case. (16.46 KB, patch)
2006-09-23 04:40 PDT, Eric Seidel (no email)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-09-12 18:33:37 PDT
RenderPath::nodeAtPoint does not propertly respect stroke width
Comment 1 Eric Seidel (no email) 2006-09-19 03:39:07 PDT
Created attachment 10643 [details]
The fix

Here is a fix.  I'm too tired right now (4am) to make a test case, but I will certainly do so before landing.
Comment 2 Maciej Stachowiak 2006-09-23 02:03:05 PDT
Comment on attachment 10643 [details]
The fix

Needs a test case but otherwise looks good to me. r- for now
Comment 3 Eric Seidel (no email) 2006-09-23 04:40:39 PDT
Created attachment 10721 [details]
Updated patch with test case.
Comment 4 Eric Seidel (no email) 2006-09-23 04:41:36 PDT
You'll notice in the patch that DRT does an awful job of with dumpAsText() for SVG files.  I filed bug 10996 to track that.
Comment 5 Eric Seidel (no email) 2006-09-26 05:51:09 PDT
r16574.  Thanks tim!