Bug 10813 – REGRESSION (r16245): double-clicking on javascript exceptions fails to show source

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Eric Seidel (no email)]

Regression: double-clicking on javascript exceptions fails to show source

Perhaps this is specific to SVG files, not sure.  Either way, this used to work.

[Eric Seidel (no email)]

Created attachment 10506 [details]
svg file containing bad javascript to trigger exception

The regression happend between in r16245 (text encoding fixes, bug 10728).
+[WebCoreFrameBridge stringWithData:textEncodingName:] is assumed to default to Latin-1 when passed nil for the encoding name, but nothing in the code supports it: TextEncoding just passes the nil down to atomicCanonicalTextEncodingName() which returns 0. The TextEncoding's m_encoding remains 0, and consequently it doesn't decode or encode.

[Eric Seidel (no email)]

Created attachment 10543 [details]
A hack-ish fix.

Not sure if this is the right way to fix it or not.

[Alexey Proskuryakov]

Comment on attachment 10543 [details]
A hack-ish fix.

r=me (yes, even without a ChangeLog entry ;) )

I think that this patch properly fixes the regression, but the behavior is still seriously broken. This code path is used when HTTP headers don't specify an encoding, but there are numerous other ways for WebCore to pick one, and the same encoding should be used for handling a resource and for providing it source, obviously. 

+    NSString* name = textEncodingName ? textEncodingName : @"Latin-1";

We usually call this encoding "iso-8859-1". Might make sense to do so here for consistency, as well.