Bug 10792 – Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators for something better

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Sam Weinig]

Bug to track this issue

[Eric Seidel (no email)]

I'm particularly uncomfortable with things like:

+        [Exclude=JS] DOMString          getPropertyShorthand(in DOMString propertyName);
+        [Exclude=JS] boolean            isPropertyImplicit(in DOMString propertyName);

where this is being used to exclude obj-c only methods from JavaScript bindings.  ObjC and JS are not going to be the only DOM bindings for long.  The KDE guys have talked about adding c++ bindings several times.  I also expect someone will eventually come along and want to add ruby, or python, or perl or whatever other bindings.  We should make this task as easy for them as possible by coding our idls in such a way as to think beyond just js and obj-c.

[Timothy Hatcher]

We could use #ifdefs and preprocess the IDL files per language.

[Sam Weinig]

Created attachment 10500 [details]
patch

- Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE) idiom.

- Assorted whitespace changes to IDL files.

[Darin Adler]

Comment on attachment 10500 [details]
patch

I think we should consider symbols more like LANGUAGE_JAVASCRIPT and LANGUAGE_OBJECTIVE_C instead of JS and OBJC, to avoid accidental substitution, say if someone had a variable named "JS".

I personally like #ifndef X better than #if !defined(X).

r=me

[Sam Weinig]

Landed in r16299.