10783 – REGRESSION (r16044): Clicking a popup changes layout around it

RESOLVED FIXED 10783

REGRESSION (r16044): Clicking a popup changes layout around it

https://bugs.webkit.org/show_bug.cgi?id=10783

Summary REGRESSION (r16044): Clicking a popup changes layout around it

mitz

Reported 2006-09-08 05:14:04 PDT

When I click the popup next to "review" on the new attachment form (see URL), the word "review" and the requestee text field move down, along with everything below them.

Attachments
reduction/testcase (179 bytes, text/html) 2006-09-10 22:32 PDT, Mike Filippone (donkeyentertain)	no flags	Details
Use a RenderBR as inner text for an empty option. Also fixes bug 11047 (14.71 KB, patch) 2007-02-08 10:48 PST, mitz	adele: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mike Filippone (donkeyentertain)

Comment 1 2006-09-10 22:32:38 PDT

Created attachment 10496 [details] reduction/testcase The problem is caused by a blank option tag. The option tag can enclose nothing at all, or whitespace (tabs, spaces, newlines), and you'll be able to reproduce the bug. However, if you have the   (or &nbsp if bugzilla doesn't escape the amp), you will not be able to reproduce the bug. It doesn't seem to matter where the blank option tag is in the select button, if there are options with text before or after -- the text will always move down a couple pixels when the blank entry is selected. And if you select an option with characters in it, the text should move back up to where it should be.

mitz

Comment 2 2006-09-10 22:45:35 PDT

Empty items are a special case because the inner div is not created if there's no text. The lazy creation of the div has caused trouble before (bug 9833). Is the extra complication necessary? (It might be if the no-text case is common).

Darin Adler

Comment 3 2006-09-11 08:33:07 PDT

(In reply to comment #2) > Empty items are a special case because the inner div is not created if there's > no text. The lazy creation of the div has caused trouble before (bug 9833). Is > the extra complication necessary? (It might be if the no-text case is common). Nah, I don't think the no-text case is common.

mitz

Comment 4 2006-09-11 10:50:33 PDT

Regressed in http://trac.webkit.org/projects/webkit/changeset/16044 (which includes "fixed baseline calculation for buttons and selects").

mitz

Comment 5 2006-09-26 22:49:22 PDT