Bug 10783 - REGRESSION (r16044): Clicking a popup changes layout around it
Summary: REGRESSION (r16044): Clicking a popup changes layout around it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Nobody
URL: http://bugzilla.opendarwin.org/attach...
Keywords: HasReduction, InRadar, Regression
: 12077 12702 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-08 05:14 PDT by mitz
Modified: 2007-02-08 18:31 PST (History)
5 users (show)

See Also:


Attachments
reduction/testcase (179 bytes, text/html)
2006-09-10 22:32 PDT, Mike Filippone (donkeyentertain)
no flags Details
Use a RenderBR as inner text for an empty option. Also fixes bug 11047 (14.71 KB, patch)
2007-02-08 10:48 PST, mitz
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-09-08 05:14:04 PDT
When I click the popup next to "review" on the new attachment form (see URL), the word "review" and the requestee text field move down, along with everything below them.
Comment 1 Mike Filippone (donkeyentertain) 2006-09-10 22:32:38 PDT
Created attachment 10496 [details]
reduction/testcase

The problem is caused by a blank option tag.  The option tag can enclose nothing at all, or whitespace (tabs, spaces, newlines), and you'll be able to reproduce the bug.  However, if you have the   (or &nbsp if bugzilla doesn't escape the amp), you will not be able to reproduce the bug.

It doesn't seem to matter where the blank option tag is in the select button, if there are options with text before or after -- the text will always move down a couple pixels when the blank entry is selected.  And if you select an option with characters in it, the text should move back up to where it should be.
Comment 2 mitz 2006-09-10 22:45:35 PDT
Empty items are a special case because the inner div is not created if there's no text. The lazy creation of the div has caused trouble before (bug 9833). Is the extra complication necessary? (It might be if the no-text case is common).
Comment 3 Darin Adler 2006-09-11 08:33:07 PDT
(In reply to comment #2)
> Empty items are a special case because the inner div is not created if there's
> no text. The lazy creation of the div has caused trouble before (bug 9833). Is
> the extra complication necessary? (It might be if the no-text case is common).

Nah, I don't think the no-text case is common.
Comment 4 mitz 2006-09-11 10:50:33 PDT
Regressed in http://trac.webkit.org/projects/webkit/changeset/16044 (which includes "fixed baseline calculation for buttons and selects").
Comment 5 mitz 2006-09-26 22:49:22 PDT
See also bug 11047.
Comment 6 Stephanie Lewis 2006-11-06 21:07:27 PST
radar 4823105


Comment 7 mitz 2007-01-02 11:52:25 PST
*** Bug 12077 has been marked as a duplicate of this bug. ***
Comment 8 mitz 2007-02-08 10:48:37 PST
Created attachment 13060 [details]
Use a RenderBR as inner text for an empty option. Also fixes bug 11047
Comment 9 Adele Peterson 2007-02-08 10:54:25 PST
Comment on attachment 13060 [details]
Use a RenderBR as inner text for an empty option. Also fixes bug 11047

Seems like a good solution to me.
Comment 10 mitz 2007-02-08 14:42:58 PST
*** Bug 12702 has been marked as a duplicate of this bug. ***
Comment 11 Mark Rowe (bdash) 2007-02-08 18:31:49 PST
Landed in r19517.