Bug 10684 – Auto-generate the Objective-C DOM CSS bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Sam Weinig]

patch in a minute

[Sam Weinig]

Created attachment 10357 [details]
patch

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule, DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule, DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet, DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

[Timothy Hatcher]

Comment on attachment 10357 [details]
patch

Looking good.

Some comments before I r+ this:

Double ChangeLog entry.

+//- (NSString *)description
+//{
+//    return [NSString stringWithFormat:@"DOMCSSStyleDeclaration: %@", [self cssText]];
+//}  

That should be removed. We can add back in descriptions per-class if we feel they are needed.

@interface DOMDocument (DOMViewCSS)
 - (DOMCSSStyleDeclaration *)getComputedStyle:(DOMElement *)elt :(NSString *)pseudoElt;
 @end

Can that be moved to another headers? DOMExtensions.h?

[Sam Weinig]

Created attachment 10373 [details]
patch 2

Updated patch addressing most of Tim's comments.  For now I have left the DOMDocument getComputedStyle method interface in DOMCSS.h as I ultimately want that to be auto-generated in DOMDocument itself, and moving it into a DOMExtension file would just mean that we have to include DOMExtension,h in DOMCSS.h.

[Timothy Hatcher]

Comment on attachment 10373 [details]
patch 2

r=me

[Sam Weinig]

Landed in r16195.