Bug 10644 - Add an embedabble KPart component for WebKit.
Summary: Add an embedabble KPart component for WebKit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 420+
Hardware: Other OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-30 14:57 PDT by Nikolas Zimmermann
Modified: 2006-09-04 15:26 PDT (History)
1 user (show)

See Also:


Attachments
General Frame adjustments (12.79 KB, patch)
2006-08-30 15:07 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Remove QtLauncher (4.97 KB, patch)
2006-08-30 15:08 PDT, Nikolas Zimmermann
eric: review+
Details | Formatted Diff | Diff
Adding WebKitPart. (28.17 KB, patch)
2006-08-30 15:09 PDT, Nikolas Zimmermann
darin: review+
Details | Formatted Diff | Diff
DumpRenderTree adjustements (8.14 KB, patch)
2006-08-30 15:10 PDT, Nikolas Zimmermann
darin: review+
Details | Formatted Diff | Diff
Update patch: General Frame adjustments (12.83 KB, patch)
2006-08-30 15:37 PDT, Nikolas Zimmermann
darin: review+
Details | Formatted Diff | Diff
Move QtLauncher down to WebKitQt (6.06 KB, patch)
2006-09-04 14:28 PDT, Nikolas Zimmermann
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-08-30 14:57:08 PDT
Instead of the simple QtLauncher tool, we need a full-featured
WebKitPart, which can be embedded in Konqueror for instance.

Adding four patches soon:
* A general patch which restructures FrameQt, to operate
  on FrameQtClient's just like Win/Mac platform code handles it.
* Remove QtLauncher.
* Adjust DumpRenderTree to the FrameQtClient code.
* Add new WebKit/WebKitPart KDE component.
Comment 1 Nikolas Zimmermann 2006-08-30 15:07:52 PDT
Created attachment 10323 [details]
General Frame adjustments
Comment 2 Nikolas Zimmermann 2006-08-30 15:08:52 PDT
Created attachment 10324 [details]
Remove QtLauncher
Comment 3 Nikolas Zimmermann 2006-08-30 15:09:27 PDT
Created attachment 10325 [details]
Adding WebKitPart.
Comment 4 Nikolas Zimmermann 2006-08-30 15:10:05 PDT
Created attachment 10326 [details]
DumpRenderTree adjustements
Comment 5 Eric Seidel (no email) 2006-08-30 15:13:56 PDT
Comment on attachment 10324 [details]
Remove QtLauncher

Looks fine.
Comment 6 Nikolas Zimmermann 2006-08-30 15:37:07 PDT
Created attachment 10327 [details]
Update patch: General Frame adjustments

Had a typo in the patch, updated.
Comment 7 Darin Adler 2006-09-03 12:17:13 PDT
Comment on attachment 10327 [details]
Update patch: General Frame adjustments

Looks good. This is an area that's changing a lot so it might be challenging to keep this compiling, but this is exactly the right direction, I believe.
Comment 8 Nikolas Zimmermann 2006-09-04 13:11:10 PDT
All has been landed by Sam Weinig, except the QtLauncher removal, as it will be moved to WebKitQt, too. (won't remove it)
Comment 9 Nikolas Zimmermann 2006-09-04 14:28:25 PDT
Created attachment 10395 [details]
Move QtLauncher down to WebKitQt

I changed my mind: QtLauncher is handy, and will be even more handy
if we differentiate between Qt/KDE only builds.
Comment 10 Sam Weinig 2006-09-04 15:26:13 PDT
Patches landed in r16214, r16215, r16216 and r16219.