Bug 10640 - Auto-generate 10 more Objective-C DOM HTML bindings
Summary: Auto-generate 10 more Objective-C DOM HTML bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-30 09:48 PDT by Sam Weinig
Modified: 2006-08-31 19:08 PDT (History)
0 users

See Also:


Attachments
patch (57.13 KB, patch)
2006-08-30 09:59 PDT, Sam Weinig
timothy: review-
Details | Formatted Diff | Diff
patch 2 (57.95 KB, patch)
2006-08-30 11:10 PDT, Sam Weinig
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-08-30 09:48:45 PDT
Splits out 10 more bindings.  Actually only 9 of them are being auto-generated, (DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement, DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement, DOMHTMLMetaElement, DOMHTMLStyleElement, DOMHTMLTitleElement) and DOMHTMLDocument has been split out into it's own file.
Comment 1 Sam Weinig 2006-08-30 09:59:20 PDT
Created attachment 10317 [details]
patch
Comment 2 Timothy Hatcher 2006-08-30 10:45:15 PDT
Comment on attachment 10317 [details]
patch

This looks good. 

One thing:

+                push(@implContent, "    $exceptionInit\n");
+                push(@implContent, "    return $getterContent;\n");
+                push(@implContent, "    $exceptionRaiseOnError\n");

That will never raise on error, since the return happens first. Should $exceptionRaiseOnError be appended before return?
Comment 3 Timothy Hatcher 2006-08-30 10:46:37 PDT
Oh that wont work either. You will need a temp var to tell.
Comment 4 Sam Weinig 2006-08-30 11:10:45 PDT
Created attachment 10318 [details]
patch 2

Addresses Tim's comments.
Comment 5 Timothy Hatcher 2006-08-30 11:27:38 PDT
Comment on attachment 10318 [details]
patch 2

Looks good. You will need to merge with my recent change, adding headers to the "Copy Generated Headers" phase and marking them "project".
Comment 6 Sam Weinig 2006-08-31 19:08:24 PDT
Landed in r16125.