Bug 10634 – -webView:dragDestinationActionMaskForDraggingInfo: is ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Karl Adam]

I've been having problems where some files were accepted as drops on my custom WebView and others were not, after some debugging I've tracked down where it all screws up and am lost on why it does it at all.

In WebHTMLView on Line 5906 the line:
  if (actionMask & WebDragDestinationActionDHTML) ...

CHANGES actionMask from it's original value to 0. This shouldn't be happening and I can't figure out why it's happening at all, but stepping through the code several times has done it every single time.

After the actionMask has been changed to 0, it of course discards the drag operation since it thinks it's uninterested in the drag and as a result my code waiting on the drop is never called, and the green + icon for copy drags never happens. So basically drags that should be working, fail.

[Mark Rowe (bdash)]

For reference, the line mentioned appears at WebKit/WebView/WebHTMLView.m:5706, not 5906.

[Karl Adam]

he way I've been able to reproduce the bug so far is by having a subclass of WebView in my application that is it's own delegate and returns WebDragDestinationAny for -webView:dragDestinationActionMaskForDraggingInfo: And Mark row is correct, I mistyped 5906 when I meant 5706.

[Karl Adam]

After building everything clean and relaunching Xcode, this is not the source of the problem, just a debugging snafu. Instead it seems what initially thought was the problem, is the problem. 

IN WebNSViewExtras -_web_dragOperationForDraggingInfo: method, [[sender draggingPasteboard] _web_bestURL] is called, and _web_bestURL returns nil if it doesn't know how to display the file type, or handle the schema. So when [WebView canShowFile:] returns NO, it jumps out, and returns nil thus causing the original webDrag method to return NSDragOperationNone and ignore the drag entirely.

I'd submit a patch to just remove the check for canShowFile: since a method called web_bestURL: shouldn't be concerned with whether or not the view can show the URL, merely return the most appropriate URL.

[Karl Adam]

Created attachment 10311 [details]
Fix file drags not natively understood by WebKit

[Eric Seidel (no email)]

Comment on attachment 10311 [details]
Fix file drags not natively understood by WebKit

A couple nits.

1.  * ChangeLog doesn't need to be in the changelog.  (That often happens when you run prepare-ChangeLog twice.)

2.  Normally changes require a copyright line.  In this case, since these are < 5 line changes, they probably don't.  But I just thought I should mention it for the future.

3.  Generally WebKit tries to avoid else statements after returns (as they're unnecessary.)    _web_dragOperationForDraggingInfo could be written cleaner by simply returning NSDragOperationCopy inside the if block and returning NSDragOperationNone outside. Execution only hits the outer return if it didn't trip the if.

Otherwise looks good.

I think we should do one more round on this patch to fix the nits.  (Since it's your first patch, it's good to be extra picky.)  But the substance looks fine.

[Karl Adam]

Created attachment 10316 [details]
Second swipe at drag patch with nits taken care of

[Timothy Hatcher]

Comment on attachment 10316 [details]
Second swipe at drag patch with nits taken care of

This is good. I will take the old ChangeLog and use it.

[Timothy Hatcher]

Landed in r16112.