Bug 10576 - Disallow copy from new password fields
Summary: Disallow copy from new password fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Adele Peterson
URL:
Keywords:
Depends on:
Blocks: 6990
  Show dependency tree / graph
 
Reported: 2006-08-25 17:44 PDT by Adele Peterson
Modified: 2006-08-30 11:25 PDT (History)
1 user (show)

See Also:

Attachments
patch (11.24 KB, patch)
2006-08-29 17:16 PDT, Adele Peterson 		no flags Details | Formatted Diff | Diff
patch w/ edited changelog (11.28 KB, patch)
2006-08-29 17:20 PDT, Adele Peterson 		adele: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2006-08-25 17:44:06 PDT 
Disallow copy from new password fields
Comment 1 Adele Peterson 2006-08-29 17:16:07 PDT 
Created attachment 10308 [details]
patch
Comment 2 Adele Peterson 2006-08-29 17:20:01 PDT 
Created attachment 10309 [details]
patch w/ edited changelog
Comment 3 Darin Adler 2006-08-30 10:52:34 PDT 
Comment on attachment 10309 [details]
patch w/ edited changelog

I don't like the idea of putting function "isPasswordField" in the base Node class. In Frame::mayCopy, you can check if something is an input element by checking hasTagName(inputTag) and then cast and call a function on HTMLInputElement.

Otherwise, this patch looks great.
Comment 4 Adele Peterson 2006-08-30 11:14:58 PDT 
Comment on attachment 10309 [details]
patch w/ edited changelog

Darin and I talked about this, and I'm addressing this by removing isPasswordField.
Comment 5 Adele Peterson 2006-08-30 11:25:59 PDT 
Committed revision 16116.