Bug 10558 – SVG should have support for <metadata> element

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Eric Seidel (no email)]

SVG should have support for <metadata> element

This will take about 10 minutes.  Most of that will be writing the test case.  The test case just needs to check to make sure that the name of the element is SVGMetadataElement.

Once this is done we'll be very close to having a complete implementation of the "structure" module for SVG 1.1 FULL.

[Rob Buis]

Created attachment 10218 [details]
First attempt

This should be enough for support of metadata element.
Cheers,

Rob.

[Eric Seidel (no email)]

Comment on attachment 10218 [details]
First attempt

I'm not sure I understand this line:
+             if([meta] == "[object SVGMetadataElement]") {


why the extra [ ] around meta?

Also, this looks wrong:
-    JSSVGDocument.h \

Other than that, this patch looks great.  r- for the JSSVGDocument.h typo.

[Eric Seidel (no email)]

rob fixed and landed this.

[Darin Adler]

Comment on attachment 10218 [details]
First attempt

The SVGMetadataElement functions should be inside the WebCore namespace, instead of "using namespace WebCore".

There's no need to declare the destructor explicitly.