Bug 10553 - Windows build fixes
Summary: Windows build fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 420+
Hardware: PC OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 10343 10520 10521 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-24 20:13 PDT by Krzysztof Kowalczyk
Modified: 2006-09-02 12:02 PDT (History)
2 users (show)

See Also:

Attachments
Windows build fixes (15.30 KB, patch)
2006-08-24 20:27 PDT, Krzysztof Kowalczyk 		hyatt: review+
Details | Formatted Diff | Diff
updated patch for win build fixes (15.44 KB, patch)
2006-08-28 13:29 PDT, Krzysztof Kowalczyk 		no flags Details | Formatted Diff | Diff
updated patch for win build fixes (v3) (233.48 KB, patch)
2006-08-30 22:17 PDT, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
updated patch for win build fixes (v3+) (15.62 KB, patch)
2006-08-30 22:30 PDT, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kowalczyk 2006-08-24 20:13:49 PDT 
Attached patch contains trivial fixes to fix up Windows-only code and Visual Studio project files to account for recent changes in core.
Comment 1 Krzysztof Kowalczyk 2006-08-24 20:27:26 PDT 
Created attachment 10209 [details]
Windows build fixes

Changes:
* fix up VS project file (add recently added/renamed functions)
* fix up windows code to account for interface changes
* rationale for build-generated-files.sh - see http://bugzilla.opendarwin.org/show_bug.cgi?id=10343

I apologize for lack of ChangeLog but due to line ending differences, svn diff thought that the whole ChangeLog files changed and diff was 1.7 MB
Comment 2 Krzysztof Kowalczyk 2006-08-24 20:29:56 PDT 
*** Bug 10343 has been marked as a duplicate of this bug. ***
Comment 3 Krzysztof Kowalczyk 2006-08-24 20:31:14 PDT 
*** Bug 10520 has been marked as a duplicate of this bug. ***
Comment 4 Krzysztof Kowalczyk 2006-08-24 20:31:56 PDT 
*** Bug 10521 has been marked as a duplicate of this bug. ***
Comment 5 Dave Hyatt 2006-08-24 20:47:43 PDT 
Comment on attachment 10209 [details]
Windows build fixes

r=me
Comment 6 David Kilzer (:ddkilzer) 2006-08-25 10:15:51 PDT 
(In reply to comment #1)
> I apologize for lack of ChangeLog but due to line ending differences, svn diff
> thought that the whole ChangeLog files changed and diff was 1.7 MB

All of the ChangeLog files have svn:eol-style set to "native".  I noticed when I check them out through svn in Cygwin that their line endings are ally "UNIX".

Is your editor changing them to DOS line endings?
Comment 7 Krzysztof Kowalczyk 2006-08-25 10:28:30 PDT 
The problem was that I initially checked out on dos but then had to run prepare changelog script in cygwin. hence newline mismatch. I've added a warning to wiki that people shouldn't check out sources on windows side (http://wiki.opendarwin.org/index.php/WebKit:Building_On_Windows). It causes problems.
Comment 8 Krzysztof Kowalczyk 2006-08-28 13:29:27 PDT 
Created attachment 10282 [details]
updated patch for win build fixes
Comment 9 Eric Seidel (no email) 2006-08-30 22:02:39 PDT 
Comment on attachment 10282 [details]
updated patch for win build fixes

Looks fine.
r=me.
Comment 10 Eric Seidel (no email) 2006-08-30 22:03:47 PDT 
Comment on attachment 10282 [details]
updated patch for win build fixes

I just tried to apply this patch to land it, and unfortunately the vcproj diff fails to apply.  Since I don't have a windows machine to test, I have to r- this.
Comment 11 Darin Fisher (:fishd, Google) 2006-08-30 22:17:03 PDT 
Created attachment 10330 [details]
updated patch for win build fixes (v3)

This is just like the previous patch except it adds "#include <windows.h>" to the following files:

  TemporaryLinkStubs.cpp
  WidgetWin.cpp
Comment 12 Darin Fisher (:fishd, Google) 2006-08-30 22:19:44 PDT 
Also, it looks like my patch changes all of the CRLFs in the vcproj to LFs.
Comment 13 Darin Fisher (:fishd, Google) 2006-08-30 22:30:06 PDT 
Created attachment 10331 [details]
updated patch for win build fixes (v3+)

OK, this one doesn't have the vcproj newline changes.
Comment 14 Darin Adler 2006-09-01 16:00:06 PDT 
Comment on attachment 10331 [details]
updated patch for win build fixes (v3+)

Looks good.

We should set the newline mode on these files to "native" so we won't have the newline troubles.
Comment 15 Adam Roben (:aroben) 2006-09-01 18:03:47 PDT 
Comment on attachment 10331 [details]
updated patch for win build fixes (v3+)

Landed as r16190. Clearing review flag.
Comment 16 Adam Roben (:aroben) 2006-09-01 18:04:11 PDT 
Comment on attachment 10282 [details]
updated patch for win build fixes

Marking obsolete and clearing review flag.