Bug 10553 – Windows build fixes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Krzysztof Kowalczyk]

Attached patch contains trivial fixes to fix up Windows-only code and Visual Studio project files to account for recent changes in core.

[Krzysztof Kowalczyk]

Created attachment 10209 [details]
Windows build fixes

Changes:
* fix up VS project file (add recently added/renamed functions)
* fix up windows code to account for interface changes
* rationale for build-generated-files.sh - see http://bugzilla.opendarwin.org/show_bug.cgi?id=10343

I apologize for lack of ChangeLog but due to line ending differences, svn diff thought that the whole ChangeLog files changed and diff was 1.7 MB

[Krzysztof Kowalczyk]

*** Bug 10343 has been marked as a duplicate of this bug. ***

[Krzysztof Kowalczyk]

*** Bug 10520 has been marked as a duplicate of this bug. ***

[Krzysztof Kowalczyk]

*** Bug 10521 has been marked as a duplicate of this bug. ***

[Dave Hyatt]

Comment on attachment 10209 [details]
Windows build fixes

r=me

[David Kilzer (:ddkilzer)]

(In reply to comment #1)
> I apologize for lack of ChangeLog but due to line ending differences, svn diff
> thought that the whole ChangeLog files changed and diff was 1.7 MB

All of the ChangeLog files have svn:eol-style set to "native".  I noticed when I check them out through svn in Cygwin that their line endings are ally "UNIX".

Is your editor changing them to DOS line endings?

[Krzysztof Kowalczyk]

The problem was that I initially checked out on dos but then had to run prepare changelog script in cygwin. hence newline mismatch. I've added a warning to wiki that people shouldn't check out sources on windows side (http://wiki.opendarwin.org/index.php/WebKit:Building_On_Windows). It causes problems.

[Krzysztof Kowalczyk]

Created attachment 10282 [details]
updated patch for win build fixes

[Eric Seidel (no email)]

Comment on attachment 10282 [details]
updated patch for win build fixes

Looks fine.
r=me.

[Eric Seidel (no email)]

Comment on attachment 10282 [details]
updated patch for win build fixes

I just tried to apply this patch to land it, and unfortunately the vcproj diff fails to apply.  Since I don't have a windows machine to test, I have to r- this.

[Darin Fisher (:fishd, Google)]

Created attachment 10330 [details]
updated patch for win build fixes (v3)

This is just like the previous patch except it adds "#include <windows.h>" to the following files:

  TemporaryLinkStubs.cpp
  WidgetWin.cpp

[Darin Fisher (:fishd, Google)]

Also, it looks like my patch changes all of the CRLFs in the vcproj to LFs.

[Darin Fisher (:fishd, Google)]

Created attachment 10331 [details]
updated patch for win build fixes (v3+)

OK, this one doesn't have the vcproj newline changes.

[Darin Adler]

Comment on attachment 10331 [details]
updated patch for win build fixes (v3+)

Looks good.

We should set the newline mode on these files to "native" so we won't have the newline troubles.

[Adam Roben (:aroben)]

Comment on attachment 10331 [details]
updated patch for win build fixes (v3+)

Landed as r16190. Clearing review flag.

[Adam Roben (:aroben)]

Comment on attachment 10282 [details]
updated patch for win build fixes

Marking obsolete and clearing review flag.