Bug 10547 - REGRESSION: Links that should open in a new window open in the same window, while opening another blank window
Summary: REGRESSION: Links that should open in a new window open in the same window, w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Darin Adler
URL: data:text/html,<a%20href="http://www....
Keywords: EasyFix, InRadar, Regression
: 10592 10637 10639 10730 10757 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-08-24 12:06 PDT by mitz
Modified: 2006-09-26 11:06 PDT (History)
10 users (show)

See Also:

Attachments
patch with change log (3.02 KB, patch)
2006-09-06 20:33 PDT, Darin Adler 		beidson: review+
Details | Formatted Diff | Diff
newer patch: "the one to land" after Brady's review (4.37 KB, patch)
2006-09-08 10:02 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2006-08-24 12:06:03 PDT 
Click the link in the URL to see the problem: a new window will open in the front, but the linked page will load in the old window.
Comment 1 Mark Rowe (bdash) 2006-08-27 20:33:07 PDT 
*** Bug 10592 has been marked as a duplicate of this bug. ***
Comment 2 mitz 2006-08-30 03:14:08 PDT 
*** Bug 10637 has been marked as a duplicate of this bug. ***
Comment 3 andgarden 2006-08-30 11:57:04 PDT 
*** Bug 10639 has been marked as a duplicate of this bug. ***
Comment 4 Matt Lilek 2006-08-30 12:53:09 PDT 
As I put in my duplicate (oops), this only happens from the r16007 nightlies and beyond (the r16002 build works as expected).
Comment 5 Neil Lee 2006-09-02 08:24:56 PDT 
Confirming - I see the same issue with the latest nightlies.
Comment 6 Mike 2006-09-02 09:29:55 PDT 
Not that you need another person confirming it, but I see it too.  If you right-click and specify open in new window that works fine.
Comment 7 mitz 2006-09-04 11:59:11 PDT 
*** Bug 10730 has been marked as a duplicate of this bug. ***
Comment 8 David Kilzer (:ddkilzer) 2006-09-06 12:12:05 PDT 
*** Bug 10757 has been marked as a duplicate of this bug. ***
Comment 9 Darin Adler 2006-09-06 20:29:52 PDT 
Very simple coding mistake. I have a fix.
Comment 10 Darin Adler 2006-09-06 20:33:55 PDT 
Created attachment 10428 [details]
patch with change log
Comment 11 Brady Eidson 2006-09-08 09:55:34 PDT 
Comment on attachment 10428 [details]
patch with change log

I discussed with Darin in IRC that perhaps the "[self release]; return;" could be managed different because it's used multiple times as the "bail out" code...  We agreed there should be an "exit method:" label and use gotos instead.  Otherwise, r+
Comment 12 Darin Adler 2006-09-08 10:02:11 PDT 
Created attachment 10466 [details]
newer patch: "the one to land" after Brady's review
Comment 13 Darin Adler 2006-09-10 13:14:58 PDT 
Committed revision 16288.
Comment 14 Darin Adler 2006-09-26 11:06:52 PDT 
Radar 4701041