Bug 10524 - svg transform: comma delimiting breaks display
Summary: svg transform: comma delimiting breaks display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.w3.org/TR/SVG/coords.html#...
Keywords: EasyFix, SVGHitList
Depends on:
Blocks:
 
Reported: 2006-08-23 06:33 PDT by jay
Modified: 2006-08-25 02:13 PDT (History)
0 users

See Also:


Attachments
A simple test case demonstrating the problem. (253 bytes, image/svg+xml)
2006-08-23 07:48 PDT, Eric Seidel (no email)
no flags Details
First attempt (8.37 KB, patch)
2006-08-23 09:46 PDT, Rob Buis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jay 2006-08-23 06:33:12 PDT
<g transform="translate(52,15), scale(.3) ">

does not display scale whereas

<g transform="translate(52,15) scale(.3) ">

does
Comment 1 Eric Seidel (no email) 2006-08-23 07:45:52 PDT
Pretty fundamental bug.  It would be nice to have a test case here though.
Comment 2 Eric Seidel (no email) 2006-08-23 07:48:56 PDT
Created attachment 10178 [details]
A simple test case demonstrating the problem.
Comment 3 Eric Seidel (no email) 2006-08-23 07:51:13 PDT
We probably need more test cases to test our parsing:
http://www.w3.org/TR/SVG/coords.html#TransformAttribute

Marking this as SVG hitlist, since we'd never ship SVG this way (especially since this is so easy to fix).
Comment 4 Rob Buis 2006-08-23 09:46:25 PDT
Created attachment 10184 [details]
First attempt

This should fix it. Let me know if more transform stuff needs to be tested.
Cheers,

Rob.
Comment 5 Darin Adler 2006-08-23 22:57:03 PDT
Comment on attachment 10184 [details]
First attempt

r=me (although mid(1) is an easier way to do what the code is doing with right())
Comment 6 Rob Buis 2006-08-25 02:13:34 PDT
Landed in r16008.