Bug 10465 – General WebKit Linux build fixes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Nikolas Zimmermann]

Building WebKit on Linux (gcc-4.1.0) highlights some problems:
* math.h includes needed in SVG* files
* RenderStyle.h has a problem with a BindingURI cast (to 0)
* Superflous Quartz includes in kcanvas

And a FrameQt friend declaration is needed in Frame.h - no bug
but needed for the Qt integration.

[Nikolas Zimmermann]

Created attachment 10103 [details]
Initial patch

[Eric Seidel (no email)]

Comment on attachment 10103 [details]
Initial patch

+        SET_VAR(css3NonInheritedData, bindingURI, (BindingURI*) 0);

confuses me.

-#include "KCanvasMaskerQuartz.h"
 #include "KCanvasRenderingStyle.h"
-#include "KCanvasResourcesQuartz.h"

was a mistake on my part, sorry.  However, are we sure this won't break the mac build?

Assuming this doesn't break the mac build, r=me.

[Nikolas Zimmermann]

(In reply to comment #2)
> (From update of attachment 10103 [details] [edit])
> +        SET_VAR(css3NonInheritedData, bindingURI, (BindingURI*) 0);
> 
> confuses me.
It also confused me & maciej - I tried 0L, NULL. Though there seems an
overloading problem, at least visible with gcc-4.1 on linux. This fixes it though... 
> 
> -#include "KCanvasMaskerQuartz.h"
>  #include "KCanvasRenderingStyle.h"
> -#include "KCanvasResourcesQuartz.h"
> 
> was a mistake on my part, sorry.  However, are we sure this won't break the mac
> build?
> 
> Assuming this doesn't break the mac build, r=me.
> 

Nope. Rob built & ran the regression tests with all of my patches yesterday...
Thanks for your time Eric!

[David Kilzer (:ddkilzer)]

Landed by rwlbuis in r15932.

[David Kilzer (:ddkilzer)]

*** Bug 10477 has been marked as a duplicate of this bug. ***