RESOLVED FIXED 10447
AffineTransform should be multi-platform compatible 
https://bugs.webkit.org/show_bug.cgi?id=10447
Summary AffineTransform should be multi-platform compatible
Nikolas Zimmermann
Reported 2006-08-16 14:19:08 PDT
platform/AffineTransform.h is CG specific and needs to be abstracted, to be implemented on other platforms (ie. Qt/Gdk).
Attachments
Proposed patch (2.71 KB, patch)
2006-08-16 14:21 PDT, Nikolas Zimmermann 		andersca: review-
DetailsFormatted DiffDiff
Final patch (2.80 KB, patch)
2006-08-16 14:58 PDT, Nikolas Zimmermann 		andersca: review+
DetailsFormatted DiffDiff
Updated "final patch" :-) (3.66 KB, patch)
2006-08-16 15:17 PDT, Nikolas Zimmermann 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-08-16 14:21:22 PDT
Created attachment 10079 [details] Proposed patch
Anders Carlsson
Comment 2 2006-08-16 14:25:07 PDT
Comment on attachment 10079 [details] Proposed patch I'm going to be extra picky since this is your first patch... I only have one comment and that is that the patch should have had a ChangeLog entry with the bug url and the title (look in the ChangeLog for some examples). You can use the prepare-ChangeLog script. So I'm marking this r-
Nikolas Zimmermann
Comment 3 2006-08-16 14:58:25 PDT
Created attachment 10080 [details] Final patch
Anders Carlsson
Comment 4 2006-08-16 15:01:48 PDT
Comment on attachment 10080 [details] Final patch r=me
Darin Adler
Comment 5 2006-08-16 15:05:04 PDT
Our original idea here was not to implement with each platform's platform-specific matrix, but rather to have a matrix implementation here shared across platforms. I'd prefer to see that rather than this, but I suppose this does no harm in the mean time.
Nikolas Zimmermann
Comment 6 2006-08-16 15:09:06 PDT
Hi Darin, I'll note that down. I think I'll come up with a patch in some days to do it properly then. Now that this patch is accepted, I can continue the Unity back-merging :-) Have a nice day, Niko
Nikolas Zimmermann
Comment 7 2006-08-16 15:17:46 PDT
Created attachment 10081 [details] Updated "final patch" :-)
Anders Carlsson
Comment 8 2006-08-16 15:18:24 PDT
Comment on attachment 10081 [details] Updated "final patch" :-) r=me
Mark Rowe (bdash)
Comment 9 2006-08-16 16:34:37 PDT
Landed in r15923.
Note You need to log in before you can comment on or make changes to this bug.