Bug 10399 - RenderTextArea is unused
Summary: RenderTextArea is unused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-14 19:54 PDT by Mark Rowe (bdash)
Modified: 2006-08-15 08:20 PDT (History)
0 users

See Also:

Attachments
Patch (17.50 KB, patch)
2006-08-14 19:57 PDT, Mark Rowe (bdash) 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2006-08-14 19:54:45 PDT 
While looking into the dead code elimination options of GCC (bug 10394) I noticed that it completely strips the implementation of RenderTextArea.  Further investigation revealed that it is now unused.
Comment 1 Mark Rowe (bdash) 2006-08-14 19:57:24 PDT 
Created attachment 10032 [details]
Patch
Comment 2 Dave Hyatt 2006-08-14 22:41:54 PDT 
Comment on attachment 10032 [details]
Patch

r=me
Comment 3 Darin Adler 2006-08-15 08:04:54 PDT 
Comment on attachment 10032 [details]
Patch

This patch doesn't go far enough!

Four other source files that can be deleted entirely if you are deleting RenderTextArea: TextBox.h, TextBoxMac.mm, WebCoreTextArea.h, WebCoreTextArea.mm.

It doesn't make sense to change the comment in WebCoreTextArea.mm -- that just makes it incorrect! What's actually going on is that's dead code too.
Comment 4 Darin Adler 2006-08-15 08:20:15 PDT 
Committed revision 15879.