Bug 10353 – XMLSerializer and DOMParser should have real implementations

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anders Carlsson]

Currently XMLSerializer and DOMParser are implemented inside of the javascript bindings.

[Anders Carlsson]

Created attachment 9989 [details]
Patch

This changes some of the semantics we have when the wrong number of arguments is passed in. We don't match Mozilla here anyway (which throws an exception) so I don't think this change is too bad.

[Darin Adler]

Comment on attachment 9989 [details]
Patch

In DOMParser::parseFromString:

+        return doc;

it would be slightly more efficient if this said return doc.release().

Also, I think it would be cleaner to have am early return if the contentType is no good rather than having the whole function be inside an if statement.

DOMParser.h does not need to include PlatformString.h. Instead it should just forward declare String as it does Document. I think the parameters of parseFromString should be named since it's not clear from their type alone what they are.

Same for XMLSerializer.h -- it can also forward-declare String, but the parameter does not need a name in that case.

These are all nitpicks, it's OK to land this as-is.

r=me

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.