Bug 10325 – [S60] Browser Control: Problem with History Stack when using custom datastore

• Status: CLOSED
• Resolution: FIXED
• Component: New Bugs

[Joseph Ligman]

TSW Bug ID: VKRR-6PT7YV (Sample code in TSW)

Case with custom data store - Crash.
For the sake of simplicity, the custom data store for the sample application is simulated by overriding the ResolveLinkL function.  

1.) Open the file Proto1BCContainer.cpp and uncomment the block of code in TBool CProto1BCContainer::ResolveLinkL function. 
2.) Change "text\\html" to "text/html" in the same file
3.) Comment out lines 71 and 72 in Proto1BCView.cpp 

4) Compile the application in CodeWarrior
5.) Complie and run the application in the emulator
6.) The application can be found in installed folder\Proto1-1st
7.) Upon invokation, the 1st HTML page with embedded link to the 2nd page will be displayed.
8.) Traverse the link.
9.) There is a typo in the html link which causes line 190 to leave from the test application.
10.) Notice that the leave is not handled in BufferTransaction.cpp

[Bradley Morrison]

Joe - please raise bugs in NEW state that you know are confirmed.

Thanks,
Bradley

[Joseph Ligman]

Created attachment 9966 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

This bug is an extension of bug 9667.

There is no data supplier provided for external links in LoadPage, so the data is not loaded. Also, client "leaves" are not handled from ResolveLinkL in the BufferTransaction's DoSubmit.function.

The test code is in TSW Bug ID: VKRR-6PT7YV. There are a few problems with the test code. 
1.) The file urls are not written correctly and the file parsing code needs to be adjusted once the urls are corrected.
2.) The content type should be text/html not text\\html

[Yongjun Zhang]

ask Sachin to review this.

[Sachin Padma]

Comment on attachment 9966 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

Can you please use currect indentation and resubmit the patch

[Joseph Ligman]

Created attachment 10077 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

cleaned up indentation

[Sachin Padma]

Comment on attachment 10077 [details]
Files: WebKitLoader.cpp, BufferTransaction.cpp

r=me

[Sachin Padma]

committed as r15925

[Krishna]

Closed.

[Shyam Sareen]

Created attachment 12744 [details]
Need additional fix: WebKitLoader.cpp

[Yongjun Zhang]

Comment on attachment 12744 [details]
Need additional fix: WebKitLoader.cpp

r=me

[Bradley Morrison]

(In reply to comment #9)
> Created an attachment (id=12744) [edit]
> Need additional fix: WebKitLoader.cpp
> 

please re-open bugs that need additional fixes. thx

[Bradley Morrison]

(In reply to comment #10)
> (From update of attachment 12744 [details] [edit])
> r=me
> 

landed - r19257. resolved.

[Krishna]

Verified and Closed.

[Joel Parks]

re-purposing InTSW keyword for use by QtWebkit team