Bug 10247 – Unable to build webkit without SVG/XPATH

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dan Wood]

For Sandvox, I want/need to build without SVG support.    It's just excess baggage I don't want to bundle into the app.

I've tried build-webkit -DSVG_SUPPORT -DXPATH_SUPPORT 

and it says:unknown option: -DSVG_SUPPORT

According to http://build.webkit.org/, TOT is not building SVG-less/XPATH-less there, either.

Build Gods, please fix?

[David Kilzer (:ddkilzer)]

I'm pretty sure you want to run this command-line to build WebKit:

./WebKitTools/Scripts/build-webkit --no-svg --release

The "--no-svg" switch implies that the xpath support is also not built.

I'm not sure why the buildbot is failing on the no-svg build.  I tried building the no-svg build locally a few  days ago and it worked just fine.  It's almost like the buildbot gets a copy of the generated SVGElementFactory.cpp source from one of the other builds and then fails to build it.  That source file should be blank with --no-svg.

[Mark Rowe (bdash)]

I don't think the build slave is doing anything wrong.  I get the following when trying a no-SVG build locally:

$ ./WebKitTools/Scripts/build-webkit --no-svg
[...]
    /usr/bin/gcc-4.0 -x objective-c++ -arch i386 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fobjc-exceptions -fpascal-strings -fasm-blocks -g -O2 -Werror -Wnon-virtual-dtor -Wnewline-eof -DNDEBUG -fmessage-length=0 -fobjc-direct-dispatch -fobjc-gc -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.4 -I/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/WebCore.build/Release/WebCore.build/WebCore.hmap -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -Wno-long-double -Wundef -Wshorten-64-to-32 -F/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/Release -I/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/Release/include -IForwardingHeaders -I. -Iicu -I/usr/include/libxslt -I/usr/include/libxml2 -I/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/Release/DerivedSources/WebCore -I/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/WebCore.build/Release/WebCore.build/DerivedSources -include /Library/Caches/com.apple.Xcode.501/SharedPrecompiledHeaders/WebCorePrefix-gkzfkakvhgixzpeqamzuxukytgdz/WebCorePrefix.h -c /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/bridge/mac/JavaAppletWidget.mm -o /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/i386/JavaAppletWidget.o
In file included from /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/EventTargetNode.h:29,
                 from /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/ContainerNode.h:29,
                 from /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/Attr.h:30,
                 from /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/Document.h:29,
                 from /Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/bridge/mac/JavaAppletWidget.mm:29:
/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/Node.h:134:5: error: "SVG_SUPPORT" is not defined
/Users/mrowe/Documents/Source/SVN/WebKit-Nightlies/WebCore/dom/Node.h:369:5: error: "SVG_SUPPORT" is not defined
[...]

Identical errors to what the buildslave is reporting.

[Sam Weinig]

Yeah, this would be my fault.  I did not test the no-svg build before adding the -Wundef flag to the projects.  Patch forthcoming.

[Graham Dennis]

Created attachment 9902 [details]
patch

I'm not sure that this is the correct fix, but...
My understanding is that before SVG_SUPPORT and XPATH_SUPPORT were changed to be set by FEATURE_DEFINES, they were set to either 1 or 0. Now it seems that it is either defined or not. So my fix is to change every #if SVG_SUPPORT or #if XPATH_SUPPORT to #ifdef SVG_SUPPORT or #ifdef XPATH_SUPPORT respectively.

[Darin Adler]

Comment on attachment 9902 [details]
patch

r=me

[David Kilzer (:ddkilzer)]

Committed revision 15828.

[David Kilzer (:ddkilzer)]

This patch didn't fix the build:

http://build.webkit.org/periodic-powerpc-mac-os-x-no-svg/builds/914/step-compile-release/0

It seems that there are no newlines on the touched files, and the new gcc warning flags are bailing on this.  (This seems odd, though, since I was able to build a release version of WebKit r15828 locally.  Not sure what the difference is.)

Filed Bug 10333 for this issue.