Bug 10176 – Make WebCore compile with -Wundef

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Sam Weinig]

Adding more gcc warning flags.

[Sam Weinig]

Created attachment 9783 [details]
patch

This patch adds -Wundef to WebCore, WebKit, JavaScriptCore, and JavaScriptGlue and fixes them so that they compile.  One idea I had was to hold off on this particular version and use this as an opportunity to convert to using the PLATFORM() macros from WTF.  We could always do that in another patch as well.

[Darin Adler]

Comment on attachment 9783 [details]
patch

+#if defined(SPEED_DEBUG) && SPEED_DEBUG < 1

That's definitely wrong. This needs to compile if SPEED_DEBUG is not defined.

THe other ones look pretty good, but I'd prefer that it consistently use #ifdef rather than a mix of #ifdef and #if defined.

Seems that all the #if __APPLE__ need to be changed too, although not on the OS X platform.

review- because of the SPEED_DEBUG mistake.

[Sam Weinig]

Darin, would something like

#if !defined(SPEED_DEBUG) || SPEED_DEBUG < 1

work?

[Darin Adler]

(In reply to comment #3)
> Darin, would something like
> 
> #if !defined(SPEED_DEBUG) || SPEED_DEBUG < 1
> 
> work?

Yes.

[Darin Adler]

(In reply to comment #1)
> One idea I had was to hold off on this
> particular version and use this as an opportunity to convert to using the
> PLATFORM() macros from WTF.

I like that idea.

[Sam Weinig]

Created attachment 9829 [details]
patch 2

This version fixes the SPEED_DEBUG issue and converts the #ifdef WIN32's from WebCore to #if PLATFORM(WIN_OS) and PLATFORM(WIN) (and in one case in config.h to #if !COMPILER(MSVC)).  Some of my choices between WIN_OS and WIN might very well be wrong because I am not entirely familiar with the WIN32 platform.

[Darin Adler]

Comment on attachment 9829 [details]
patch 2

Not sure why you changed "many" to "majy" in the change log.

But, otherwise, looks great.

r=me

[Sam Weinig]

Landed in r15781.