Bug 10169 – REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

If you drag text from any <input type="text"> element to a textarea (e.g. from URL: to Description: on the bug report page), the text disappears from the input element, but doesn't enter the textarea. Instead, nothing is added to the textarea, and it becomes "semi-selected" -- it gets the blue square, but not the cursor.

[Darin Adler]

The problem here is in WebCore::Frame::appliedEditing.

When you drop the text into the <textarea>, the new select is inside the <texarea>. So the appliedEditing function ends up focusing the <texarea> when setSelection is called.

But it's only after that when dispatchEditableContentChangedEvent is called. There are other things wrong too, for example, if the selection delegate refuses to change the selection then we won't communicate where the change took place, which is incorrect. Whether the selection moves or not is unimportant.

I'll try rearranging code to fix this.

[Darin Adler]

Created attachment 9893 [details]
editing cleanup patch that fixes this bug (needs change log, tests)

[Darin Adler]

Created attachment 10186 [details]
editing cleanup patch that also fixes this bug, including change log and test

Comment on attachment 10186 [details]
editing cleanup patch that also fixes this bug, including change log and test

+    // FIXME: Ugh, don't want delays in layout tests!
+    eventSender.leapForward(400);
leapForward() works by offsetting the timestamps on subsequent events, so there's no delay.

[Justin Garcia]

Comment on attachment 10186 [details]
editing cleanup patch that also fixes this bug, including change log and test

r=me

[Darin Adler]

(In reply to comment #4)
> (From update of attachment 10186 [details] [edit])
> +    // FIXME: Ugh, don't want delays in layout tests!
> +    eventSender.leapForward(400);
> leapForward() works by offsetting the timestamps on subsequent events, so
> there's no delay.

OK. Great. I'll remove that comment.

[Darin Adler]

Committed revision 16026.