RESOLVED FIXED 10158
REGRESSION: Selection highlight is dark and opaque when solid-color images are used 
https://bugs.webkit.org/show_bug.cgi?id=10158
Summary REGRESSION: Selection highlight is dark and opaque when solid-color images ar...
mitz
Reported 2006-07-29 23:28:10 PDT
The painting code for solid color images changes the graphics context's composite operation without restoring it. In the test case, it affects the selection highlight, making it paint without transparency.
Attachments
Test case (677 bytes, text/html)
2006-07-29 23:28 PDT, mitz 		no flags
Details
Add calls to save and restore the graphics context (18.75 KB, patch)
2006-07-29 23:30 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-07-29 23:28:49 PDT
Created attachment 9760 [details] Test case
mitz
Comment 2 2006-07-29 23:30:58 PDT
Created attachment 9761 [details] Add calls to save and restore the graphics context
Darin Adler
Comment 3 2006-07-30 09:26:33 PDT
Comment on attachment 9761 [details] Add calls to save and restore the graphics context It's not clear what the best policy is for various graphics context attributes. For some, we assume that every user has to set the value before drawing. For others, it's the responsibility of the client to save and restore if they change an attribute. I suppose that composite operation is a member of the latter group. But I don't like the ad hoc nature and lack of clarity about which operations fall into which category. r=me
Darin Adler
Comment 4 2006-07-30 19:14:01 PDT
(In reply to comment #3) > (From update of attachment 9761 [details] [edit]) > It's not clear what the best policy is for various graphics context attributes. Ah, but in this case it's probably necessary to save and restore since this is inside a "draw image" abstraction.
Darin Adler
Comment 5 2006-07-31 23:07:10 PDT
Committed revision 15733.
Note You need to log in before you can comment on or make changes to this bug.