CLOSED FIXED 10110
[S60] Cache problem: expiration of max-age header value and expiration of expires header value don't work in Webkit 
https://bugs.webkit.org/show_bug.cgi?id=10110
Summary [S60] Cache problem: expiration of max-age header value and expiration of exp...
Shyam Sareen
Reported 2006-07-25 14:16:16 PDT
The TWS error bug is TSCT-6Q3F4V. --------------------------------------- Test following two case: BRW_CCH-Cache01-001 Test link: Go to http://www3.wirelessfuture.com:8080/3UK/index.html => Cache Management => Browser-CCH-Cache[01-05] => BRW_CCH-Cache01-001 Step: To test whether the page is cached or not after the expiration of max-age header value. Select the test relative page. Once the loading is finished, select the link "Test max-age". Repeat. Expected result: In 100 seconds from first "Test max-age" click, the page is taken from the cache and date is not modified. After 100 seconds, the page is loaded and the date is refreshed. Test result: the "current time" dind't change after 100s. BRW_CCH-Cache04-004 Test link: Go to http://www3.wirelessfuture.com:8080/3UK/index.html => Cache Management => Browser-CCH-Cache[01-05] => BRW_CCH-Cache04-004 Step: To test whether the page is cached or not after the expiration of expires header value. Select the test relative page. Once the loading is finished, select the link "Test expires". Repeat. Expected result: In 120 seconds from first "Test expires"click, the page is taken from the cache and date is not modified. After 120 seconds, the page is loaded and the date is refreshed. Test result: the "current time" didn't change after 120s.
Attachments
Contains the difference between the source files. (2.47 KB, patch)
2006-07-27 07:01 PDT, Shyam Sareen 		Sachin.Padma: review-
DetailsFormatted DiffDiff
Code review for max-age for cache control. (4.78 KB, patch)
2006-08-08 06:30 PDT, Shyam Sareen 		zalan: review-
DetailsFormatted DiffDiff
Review please in the max - age of cache header. (6.88 KB, patch)
2006-08-09 07:46 PDT, Shyam Sareen 		yongjun.zhang: review-
DetailsFormatted DiffDiff
Adjusted the identitation (4.86 KB, patch)
2006-08-09 10:51 PDT, Shyam Sareen 		yongjun.zhang: review-
DetailsFormatted DiffDiff
Again fixed the problem. (5.31 KB, patch)
2006-08-09 14:04 PDT, Shyam Sareen 		yongjun.zhang: review+
DetailsFormatted DiffDiff
Add change log entry. (6.17 KB, patch)
2006-08-09 15:11 PDT, Shyam Sareen 		bradley.morrison: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Bradley Morrison
Comment 1 2006-07-25 16:01:09 PDT
Can confirm
Shyam Sareen
Comment 2 2006-07-27 07:01:50 PDT
Created attachment 9712 [details] Contains the difference between the source files.
Bradley Morrison
Comment 3 2006-07-27 07:11:39 PDT
Comment on attachment 9712 [details] Contains the difference between the source files. Sachin - please review.
Sachin Padma
Comment 4 2006-07-27 07:31:00 PDT
Comment on attachment 9712 [details] Contains the difference between the source files. The maxAge, maxStale, minFresh are in seconds. SO they need to be converted to microseconds.
Shyam Sareen
Comment 5 2006-08-08 06:30:40 PDT
Created attachment 9935 [details] Code review for max-age for cache control.
zalan
Comment 6 2006-08-08 08:24:21 PDT
Comment on attachment 9935 [details] Code review for max-age for cache control. please fix identations (in both files) and ask Sachin to review this patch. it would be better to move this piece of code to a seperate function (something like fixresponsetime) as ReceivedResponseHeadersL is getting too big. - and add some logging.
Shyam Sareen
Comment 7 2006-08-09 07:46:36 PDT
Created attachment 9955 [details] Review please in the max - age of cache header. Made required changes as suggested by Zalan.
Yongjun Zhang
Comment 8 2006-08-09 09:59:43 PDT
Comment on attachment 9955 [details] Review please in the max - age of cache header. The identations (in the newly added function) is still not right, could you fix it? Plus, please ask Zalan to review it too because he is the expert in this area.
Shyam Sareen
Comment 9 2006-08-09 10:51:33 PDT
Created attachment 9958 [details] Adjusted the identitation Already reviewed from Zalan.
Yongjun Zhang
Comment 10 2006-08-09 12:49:27 PDT
Comment on attachment 9958 [details] Adjusted the identitation identitation is still not right, and there are also tabs in the code.
Shyam Sareen
Comment 11 2006-08-09 14:04:08 PDT
Created attachment 9963 [details] Again fixed the problem.
Yongjun Zhang
Comment 12 2006-08-09 14:16:30 PDT
Comment on attachment 9963 [details] Again fixed the problem. r=me
zalan
Comment 13 2006-08-09 14:59:15 PDT
changelog entry is missing.
Shyam Sareen
Comment 14 2006-08-09 15:11:57 PDT
Created attachment 9965 [details] Add change log entry.
zalan
Comment 15 2006-08-09 15:29:05 PDT
Comment on attachment 9965 [details] Add change log entry. r=me
zalan
Comment 16 2006-08-09 15:31:13 PDT
r15826
Krishna
Comment 17 2006-08-10 10:41:17 PDT
This is no longer reproducible on the hw with the applied patches. But this is still reproducible in the Reindeer at r15828. Bug is REOPENED
Eric Seidel (no email)
Comment 18 2006-09-21 02:26:03 PDT
Given that the last comment was over a month ago, I'm wondering if this got landed. If it's been landed but re-opened, the review flag should be cleared so that it does not appear in any of the "need to commit" queries. If it has been landed and can be closed, it should be closed. Thanks!
Bradley Morrison
Comment 19 2006-09-21 07:33:25 PDT
Comment on attachment 9965 [details] Add change log entry. Issue still exists in emulator, clearing review flag so I clearing the review flag.
Bradley Morrison
Comment 20 2006-09-21 07:33:26 PDT
Comment on attachment 9965 [details] Add change log entry. Issue still exists in emulator, clearing review flag so I clearing the review flag.
Krishna
Comment 21 2007-01-25 18:52:20 PST
Verified and Closed.
Note You need to log in before you can comment on or make changes to this bug.