Bug 10086 - Regression: Drawing SVG lighting filters is broken
Summary: Regression: Drawing SVG lighting filters is broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://www.w3.org/Graphics/SVG/Test/2...
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-07-24 00:45 PDT by Eric Seidel (no email)
Modified: 2007-10-01 08:49 PDT (History)
1 user (show)

See Also:


Attachments
patch where something goes wrong (32.38 KB, patch)
2006-07-24 00:54 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2006-07-24 00:45:14 PDT
Regression: Drawing SVG lighting filters is broken

This is seen on refresh:

2006-07-24 03:43:30.562 Safari[15847] unlockFocus called too many time.
2006-07-24 03:43:30.564 Safari[15847] unlockFocus called too many time.
Comment 1 Oliver Hunt 2006-07-24 00:51:59 PDT
This also breaks text layout for the first row.

This is a regression caused by patch 14918
Comment 2 Eric Seidel (no email) 2006-07-24 00:52:38 PDT
This was caused by http://bugzilla.opendarwin.org/show_bug.cgi?id=9488 according to oliver.
Comment 3 Oliver Hunt 2006-07-24 00:54:04 PDT
Created attachment 9647 [details]
patch where something goes wrong

Not for review, something in this caused the badness
Comment 4 Oliver Hunt 2006-07-24 07:08:35 PDT
Okles the change to WebCore::RenderSVGImage::relativeBBox causes the layout to be bludgeoned.
Comment 5 Oliver Hunt 2006-07-26 07:11:13 PDT
and in fact the patch does only bludgeon layout -- there are a couple of crashes, possibly with the same root cause.  I am now stepping back by ever increasing amounts, and scrolling with the above url is still crashing at revision 14700
Comment 6 Oliver Hunt 2006-07-26 07:32:13 PDT
Alex pointed out on IRC that the crash may in fact be a regression triggered by the 10.4.7 update -- anyone got a 10.4.6 box available?

Comment 7 Oliver Hunt 2006-08-11 06:46:49 PDT
Okay am splitting the layout bug out of this one... 
Comment 8 Eric Seidel (no email) 2007-10-01 08:49:45 PDT
It seems WildFox has fixed lighting filters on feature-branch, except perhaps for spotlight filters.