| Summary: | Fix viewBox issues in Hixie's test | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rwlbuis> | ||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 420+ | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.4 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 6018 | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2006-07-15 12:45:48 PDT
Created attachment 9467 [details]
First attempt
This patch should fix the problem. Let me know if the bug requires testcases, like
Hixie's 010 and 011 error tests.
Cheers,
Rob.
Test for new email address, ignore. (In reply to comment #1) > Created an attachment (id=9467) [edit] > First attempt > > This patch should fix the problem. Let me know if the bug requires testcases, > like > Hixie's 010 and 011 error tests. > Cheers, > > Rob. > Comment on attachment 9467 [details]
First attempt
Code change looks OK. Ideally we'd do the work without converting the string to ASCII.
But the patch doesn't include a test case or changes to existing test results. So review- just for that.
Created attachment 9681 [details]
Now with testcase
The new patch has the two testcases, taken literally from Hixie's tests but renamed. Also
included are the .png, .checksum files, not sure whether they need to be part of this patch, but
I'll need them for landing for sure :)
Cheers,
Rob.
Comment on attachment 9681 [details]
Now with testcase
r=me
|