run-webkit-tests should provide pixel comparisons of failing tests

• Component: Tools / Tests
• Status: NEW ---

When a layout test fails, it is often useful to compare the "failed" rendering with the expected rendering. The color profile acrobatics are probably not necessary in this case.

[David Kilzer (:ddkilzer)]

So you're saying that when you run run-webkit-tests without the --pixel option, you still want the pixels generated regardless for the failure (without the color profile acrobatics)?

(In reply to comment #1)
> So you're saying that when you run run-webkit-tests without the --pixel option,
> you still want the pixels generated regardless for the failure (without the
> color profile acrobatics)?

Yes.

[David Kilzer (:ddkilzer)]

Should this feature always happen, or should there be a command-line switch?

If it should be a switch, what should it be called?  Something like --generate-pixel-on-error, except shorter?

(In reply to comment #3)
> Should this feature always happen, or should there be a command-line switch?
> 
> If it should be a switch, what should it be called?  Something like
> --generate-pixel-on-error, except shorter?
> 

In my opinion, it should be the default, but there should be a way to disable it. Perhaps --no-pixel-on-error ?