Summary: | Windows build fails with link error CharsetTable not defined | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Goodger <bengoodger> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Blocker | CC: | bugs-webkit, gavin.sharp | ||||
Priority: | P1 | ||||||
Version: | 420+ | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Ben Goodger
2006-06-18 23:58:00 PDT
Created attachment 8918 [details]
patch
move test for equality to "none" to after normalization steps.
ChangeLog entry:
* platform/make-charset-table.pl:
(process_iana_charsets):
Move test for equality to alias "None" until after normalization steps
to ensure escape characters in the input data don't interfere with
processing.
Convert nearby tabs to 4 spaces in this function.
Comment on attachment 8918 [details]
patch
This looks fine -- but I'm working on a patch that eliminates the character set table entirely!
Comment on attachment 8918 [details]
patch
Seems fine to land this, but even better to remove this script entirely!
r=me
Committed revision 14919. |