Summary: | [S60] Result page is not loaded completely on www.expedia.com | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Krishna <krishnamurty.podipireddy> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | CLOSED FIXED | ||||||||
Severity: | Normal | CC: | ian, koivisto, S60webkit | ||||||
Priority: | P2 | Keywords: | PlatformOnly | ||||||
Version: | 312.x | ||||||||
Hardware: | S60 Hardware | ||||||||
OS: | S60 3rd edition | ||||||||
URL: | http://www.expedia.com | ||||||||
Bug Depends on: | 5312 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Krishna
2006-05-23 13:23:06 PDT
I can't reproduce this bug with Version 2.0.3 (418.3). Page seems to full load in TOT, but nothing happens when I select the first car. Changed Version to reflect that this is also a problem in TOT. Expedia populates car rental entries by replacing comments in HTML with actual data. In the S60 browser code base,comment nodes are not created when <!--c--> is encountered. Here is piece of HTML that causes the problem on the S60 browser: function writeCarRow2(s, c, v) { s = s.replace(/<!--C-->/,c.carccart); .... } For the Safari browser, Expedia sends out "<!--c-->" instead of "<!--c-->" and thats why the string replace works fine. This would work on the S60 HW if fix for #5312 is available. Given previous comment, should the PlatformOnly keyword be added to this bug? (In reply to comment #4) > Given previous comment, should the PlatformOnly keyword be added to this bug? I filed Bug 9165 to cover the ToT (tip-of-tree) WebKit issue, so I'm adding PlatformOnly to this bug and changing Version back to 312.x. TSW Error ID: ASHA-6J97FA This search results page for Expedia seems to do some user-agent sniffing. This is HIGHLY SPECULATIVE, but the issue MIGHT be a server-side issue where the page might hang because it doesn't know what to output given the user agent string. (Note that this is easily testable--just fake a user agent string to see the content change.) I haven't completed testing on Bug 9165 yet (see Bug 9165 Comment #4), but it looks like if a WebKit-esque user agent string is sent, you will get the desired "<!--c-->" output on the page. S60 Bug 9189 may also be related (or may cause similar problems to be exhibited as Bug 9165). Created attachment 10171 [details]
Fix taken from Tiger branch (see comments)
Comment on attachment 10171 [details]
Fix taken from Tiger branch (see comments)
changeset_r14419 & changeset_r14187
Comment on attachment 10171 [details]
Fix taken from Tiger branch (see comments)
- documentElement optimization should be like in tot
- no need to change tokenizer constructor defaults, just change it where it is constructed
- check if parser change in tot needs to be brought in as well
Created attachment 10312 [details]
Made changes based on comments
Comment on attachment 10312 [details]
Made changes based on comments
Couldnt make the change for HTMLParser::handleError method as it is not implemented in S60 codebase
Comment on attachment 10312 [details]
Made changes based on comments
r=me
Bug 10674 blocks verification of this bug. Verified and Closed. |