| Summary: | REGRESSION: Inspector tree does not render at the correct size | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED WORKSFORME | ||||||||||||||
| Severity: | Major | CC: | ian, sam | ||||||||||||
| Priority: | P1 | Keywords: | InRadar | ||||||||||||
| Version: | 420+ | ||||||||||||||
| Hardware: | Mac | ||||||||||||||
| OS: | OS X 10.4 | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 9018 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Timothy Hatcher
2006-05-19 18:49:12 PDT
Created attachment 8423 [details]
Picture showing the problem
This regression was caused by bug 7604. See the attached pictures of before and after. Created attachment 8424 [details] Before bug 7604 landed (r14350) Created attachment 8425 [details] After bug 7604 landed (r14357) Created attachment 8426 [details] Simple test case that shows the regression This test shows the regression. This is a regression from shipping Safari since r14350. This only happens if the element "c" (the red block) is an object, img or other replaced element. Make element c a div and it works. Element "c" specifies height of 100%, but it is a child of element "b" that has no specified height (auto). Element "a" has a height and that is the height element "c" is reflects with 100%. Created attachment 8439 [details]
patch
This patch does fix the issue, but I think that a more thought out fix might serve quite a bit better. I also was not able to test this in the test suite so if that reason alone it should not be landed. I would really appreciate any comments.
I don't think a new method is necessary. I'd just do it inline. I'm really curious what caused the regression though. What change broke the test? This is no longer broken, something else must have fixed this. |