Summary: | Clean up setShouldAntialias/setUseAntialiasing on GraphicsContext | ||
---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
Component: | Layout and Rendering | Assignee: | Rob Buis <rwlbuis> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | darin, eric |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Mac | ||
OS: | OS X 10.5 |
Description
Simon Fraser (smfr)
2009-01-19 16:58:52 PST
Hi Simon, (In reply to comment #0) > The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, > GraphicsContexet already has: > > void setShouldAntialias(bool); > bool shouldAntialias() const; > > so now we have 2 antialiasing methods. This needs cleaning up. Ok, I'll have a look tonight. Cheers, Rob. Hi Simon, (In reply to comment #0) > The patch for bug 16182 added GraphicsContext::setUseAntialiasing(). However, > GraphicsContexet already has: > > void setShouldAntialias(bool); > bool shouldAntialias() const; > > so now we have 2 antialiasing methods. This needs cleaning up. Now that I looked at it, setUseAntialiasing is gone! It was removed in the same patch that added setShouldAntialias .Also the shape-rendering.svg test still works fine, so I think this report can be closed. Cheers, Rob. PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am not sure in what context that is important? (In reply to comment #2) > PS: I do see setUseAntialiasing mentioned in WebCore/WebCore.order, but I am > not sure in what context that is important? That’s a file used to optimize performance on Mac OS X that has to be regenerated from time to time by actually testing some usage scenarios. It’s quite out of date at the moment. There’s no harm in having it mention a function that doesn’t exist. OK, sorry about filing this. I was confused by a conflict I had with some local changes. I think we're all good. |