Summary: | [Gtk] SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alp | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jan Alonzo
2008-08-07 07:34:43 PDT
Created attachment 22697 [details]
use G_PRIORITY_DEFAULT_IDLE for g_idle_add function
(In reply to comment #0) > In setSharedTimerFireTime: > > if (intervalInMS == 0) > - sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT, timeout_cb, NULL, > NULL); > + sharedTimer = g_idle_add_full(G_PRIORITY_DEFAULT_IDLE, timeout_cb, > NULL, NULL); > > I'm attaching a patch for this. > Did this cause incorrect behaviour or is this patch just a cleanup? How about just using g_idle_add() (docs suggest it does the same thing)? Created attachment 22715 [details]
updated to use g_idle_add rather than the _full variant
Hi Alp
This is just a cleanup. I've updated the patch to use g_idle_add rather than g_idle_add_full.
Comment on attachment 22715 [details]
updated to use g_idle_add rather than the _full variant
Please adjust the changelog when landing. According to the glib documentation g_idle_add is there from the beginning so we can safely use that.
|