| Summary: | Remove usage of useQmake() from WebKitTools/Scripts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jan Alonzo <jmalonzo> | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | Keywords: | Gtk | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Jan Alonzo
2008-05-22 06:13:37 PDT
Created attachment 21292 [details]
Remove traces of useQmake
This patch removes traces of useQmake and just use isQt() if necessary. Also fixes a couple of typo ("Web Kit")
Comment on attachment 21292 [details]
Remove traces of useQmake
-$productDir .= "/Programs" if (isGtk() && not useQmake());
That change seems to change behavior since useQmake() was false before. Why is it OK to change behavior here?
Patch otherwise looks great.
Created attachment 21323 [details]
Updated per Darin's review
Hi Darin
Thanks. I added the line again and applied the same to run-webkit-tests.
Cheers
Comment on attachment 21323 [details]
Updated per Darin's review
r=me
|