Bug 17050

Summary: WIN32_LEAN_AND_MEAN fails to compile
Product: WebKit Reporter: Tony Chang <tony>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
add #ifndef guards
none
extra include in webcore eric: review+

Description Tony Chang 2008-01-28 14:16:53 PST 
The #define for WIN32_LEAN_AND_MEAN and _CRT_RAND_S should check for existing definitions because it could be defined project wide and conflict (or just be a duplicate #define).  This is causing a problem for my build because I define these project wide.
Comment 1 Tony Chang 2008-01-28 14:17:35 PST 
Created attachment 18743 [details]
add #ifndef guards
Comment 2 Darin Adler 2008-01-28 14:22:15 PST 
Comment on attachment 18743 [details]
add #ifndef guards

Seems harmless. r=me
Comment 3 Tony Chang 2008-02-01 17:31:27 PST 
Created attachment 18865 [details]
extra include in webcore

This is the only other change needed before being able to compile WebCore with WIN32_LEAN_AND_MEAN.
Comment 4 Eric Seidel (no email) 2008-02-02 15:16:22 PST 
Comment on attachment 18743 [details]
add #ifndef guards

landed this first patch as r29941
Comment 5 Eric Seidel (no email) 2008-02-02 15:18:57 PST 
Comment on attachment 18865 [details]
extra include in webcore

This also seems harmless.  It's currently included by:
platform/win/DragDataWin.cpp:#include <objidl.h>
platform/win/WCDataObject.h:#include <objidl.h>

Perhaps it should be moved to WebCorePrefix.h at some point.
Comment 6 Eric Seidel (no email) 2008-02-02 15:20:38 PST 
Landed second patch as r29942.