Summary: | [Gtk] JavaScriptCore needs -lpthread | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Seo Sanghyeon <sanxiyn> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alp, mh+webkit, mrowe | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 16411 | ||||||||||
Attachments: |
|
Description
Seo Sanghyeon
2007-12-11 19:16:46 PST
Created attachment 17858 [details]
Include -lpthread
Comment on attachment 17858 [details] Include -lpthread You should set the review flag to ? if you'd like your patch looked at for review. You should also include a description of your change in the ChangeLog at JavaScriptCore/ChangeLog. See http://webkit.org/coding/contributing.html for more info. The change looks fine to me. It's not great to always add -lpthread as some platforms may not use pthreads, but as JavaScriptCore makes the assumption that they do when building multi-threaded I think it's fine for the meantime. Marking as r- for now pending a ChangeLog entry. Thanks for the patch! Created attachment 17859 [details]
Remove kjs pthread dependency
Proposed fix (needs review from someone who knows the collector and what correct behaviour is when threading is disabled)
Comment on attachment 17859 [details]
Remove kjs pthread dependency
That will prevent the stack from being scanned at all, which is really bad.
Check out bug #15118, which is exactly the same issue, except that in the end, I couldn't reproduce with the icu not having -lpthread in its -config script. (In reply to comment #5) > Check out bug #15118, which is exactly the same issue, except that in the end, > I couldn't reproduce with the icu not having -lpthread in its -config script. It could actually be reproduced by debian buildds... http://buildd.debian.org/fetch.cgi?pkg=webkit;ver=0%7Esvn27674-1;arch=sparc;stamp=1197008842 Created attachment 17864 [details]
Prospective build fix
This patch links to pthread only when not building on Windows, and does it in JavaScriptCore.pri rather than testkjs.pro as proposed previously.
Untested since I can't reproduce the build breakage. Can someone try this?
Comment on attachment 17864 [details]
Prospective build fix
Build fix; tested and works.
|