Summary: | a few SunSpider script improvements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | Tools / Tests | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | ||||||
Priority: | P2 | ||||||
Version: | 523.x (Safari 3) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Darin Adler
2007-10-28 14:33:10 PDT
Created attachment 16920 [details]
patch
Comment on attachment 16920 [details]
patch
+system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f", "resources/sunspider-analyze-results.js");
You could remove the quotes from around $jsShellPath while you're at it.
+ $foundOutput = 0;
+ $foundStart = 1;
+ $result = "[{\n";
Looks like you've got some tabs here.
} else {
- if (/^[}][]]$/) {
+ print;
Did you intend to insert this print statement?
+ s/;*$//;
Do we really expect to have multiple semi-colons here?
r=me
(In reply to comment #2) > +system("$jsShellPath", "-f", $prefixFile, "-f", $resultsFile, "-f", > "resources/sunspider-analyze-results.js"); > > You could remove the quotes from around $jsShellPath while you're at it. Done. > + $foundOutput = 0; > + $foundStart = 1; > + $result = "[{\n"; > > Looks like you've got some tabs here. Hmm, the pre-existing file seems to have some tabs. Removed > } else { > - if (/^[}][]]$/) { > + print; > > Did you intend to insert this print statement? Oops! > + s/;*$//; > > > Do we really expect to have multiple semi-colons here? I'll switch to ? instead of *. |