Bug 14008

Summary:

RenderTextControl.cpp hard-codes scrollbar size to 15 pixels

Product:

WebKit

Reporter:

Darin Fisher (:fishd, Google) <fishd>

Component:

Platform

Assignee:

Darin Fisher (:fishd, Google) <fishd>

Status:

RESOLVED FIXED

Severity:

Minor

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
simple patch	hyatt: review+

Description Darin Fisher (:fishd, Google) 2007-06-05 19:47:55 PDT

RenderTextControl.cpp hard-codes scrollbar size to 15 pixels

the comments say that this should use RenderTheme instead.  after discussing with maciej on #webkit, it seems like the best solution is a method on RenderTheme that takes a RenderObject parameter so that the scrollbar size can vary (e.g., on OS X, mini controls have a smaller scrollbar).

Comment 1 Darin Fisher (:fishd, Google) 2007-06-05 20:42:23 PDT

Created attachment 14874 [details]
simple patch

I went with the simpler version of the patch since other code in rendering/ invokes PlatformScrollbar::horizontalScrollbarHeight()/verticalScrollbarWidth()

Moreover, this ends up not being a real code change since it's just replacing a hard-coded 15 with a static function that returns 15 (on Mac).

Comment 2 Dave Hyatt 2007-06-05 20:59:41 PDT

Comment on attachment 14874 [details]
simple patch

r=me

Comment 3 Mark Rowe (bdash) 2007-06-05 21:28:26 PDT

Landed in r22017.