Bug 12374

Summary:

Performance optimization to patch for Bug 10773

Product:

WebKit

Reporter:

Sanjay Madhav (chmmravatar) <sanjay12>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Enhancement

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch as described	ggaren: review-

Description Sanjay Madhav (chmmravatar) 2007-01-22 21:52:31 PST

Simple optimization: don't bother calling markDOMNodesForDocument if the JSDocument was already marked.

Comment 1 Sanjay Madhav (chmmravatar) 2007-01-22 21:53:21 PST

Created attachment 12618 [details]
patch as described

Comment 2 Geoffrey Garen 2007-01-22 22:18:23 PST

Comment on attachment 12618 [details]
patch as described

Our convention is that the caller is responsible for checking !marked() before calling mark(), so this optimization should have no effect.

Do you know of a code path that marks a JSDocument before checking !marked()?

Comment 3 Sanjay Madhav (chmmravatar) 2007-01-22 22:54:09 PST

Oh, you're right. Nevermind this, closing it out. Just thought I had missed it and wanted to be certain.