Summary: | REGRESSION: No day/week scrollbar in Google Calendar | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> | ||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, koivisto, sullivan | ||||||
Priority: | P1 | Keywords: | GoogleBug, InRadar, NeedsReduction, Regression | ||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Matt Lilek
2006-12-26 12:01:19 PST
Created attachment 13109 [details]
make sure overflow:auto scrollbars are enabled
Google Calendar apparently dynamically turns overflow:scroll scrollbars into overflow:auto. If they were disabled at that point they would never be enabled
Antti, as far as I can tell it looks good, but it needs a test case. Comment on attachment 13109 [details]
make sure overflow:auto scrollbars are enabled
Fix looks good to me. Just needs a test case for LayoutTests. r- for now, r=me if you add a test case.
Created attachment 13112 [details]
test case
Interestingly this test case fails also in tiger webkit. Since this bug depends on layout timing Calendar scrollbars probably work there just by accident.
Antti, the test case looks good, now, if you could just bundle it all together. add a Changelog for the LayoutTest and upload it we will be all set. Based on comment #4 committed as r19566 with the attached LayoutTest This appears only partly fixed. With tip of tree, if I visit Google calendar in day or week mode, no vertical scroller appears. But if I click on the "month" tab, then back on the "day" or "week" tab, the vertical scroller then appears, and works correctly. So there's some initial state that's still wrong. Worksforme. Err, are you sure you actually have r19566 or newer? This also works for me with r19573. Hmm, I definitely have 19573. I'll double-check this. Ah, I was building a Release version, but testing on a Debug version that wasn't quite up to date. When I test on a version that actually includes this fix, it works just fine. D'oh! |